-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Update binarycaching.md with clearer description #18033
Conversation
We received user feedback about the binary caching feature not being clear. I rewrote some of the opening section to try to describe it better. Feedback is appreciated.
Co-authored-by: ras0219 <[email protected]>
There are few things unclear left:
|
I agree, thank you for the feedback! I'll work with Robert to address these questions in the PR. |
There is the implementation notes section, however the ABI is explicitly non-normative -- we fully intend to add additional fields and content to it in the future.
Unfortunately there's no way for vcpkg to determine what's truly "dead"; you could have a 3 month old instance of vcpkg on your disk that you've moved from its original location, so there's no way we could track it. As for the actual operation of cleaning, it's backend specific. For files, they can just be deleted. For NuGet / Cloud providers, it's up to those specific providers on how they offer "cleaning" services.
Unfortunately, abi compatibility is extremely specific to the compilers and can even vary based on flags. For example, LTO/LTCG usually changes the abi compatibility computation. Because of this, we take a conservative approach to ensure correctness. |
We received user feedback about the binary caching feature not being clear. I rewrote some of the opening section to try to describe it better. Feedback is appreciated.
Describe the pull request
What does your PR fix?
Small documentation fix.
Does your PR follow the maintainer guide?
Yes