Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transwarp] add a new port #18069

Merged
merged 5 commits into from
May 26, 2021
Merged

Conversation

niyue
Copy link
Contributor

@niyue niyue commented May 23, 2021

Describe the pull request

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@niyue
Copy link
Contributor Author

niyue commented May 23, 2021

Hi there,

I find there is one check failed, saying file's SHA on x86_windows's is incorrect.

Error: While reading versions for port transwarp from file: C:\a\1\s\versions\t-\transwarp.json
       File declares version `2.2.2` with SHA: a21d15430c4c31ab2e8f597191578b33862ff234
       But local port with the same verion has a different SHA: 532341b073fc648d89f9430488535076bbe34e05
       Please update the port's version fields and then run:
vcpkg x-add-version transwarp

I did run ./vcpkg x-add-version --all before submitting the PR, do I still need to run vcpkg x-add-version transwarp for it?

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 24, 2021
ports/transwarp/CONTROL Outdated Show resolved Hide resolved
ports/transwarp/portfile.cmake Outdated Show resolved Hide resolved
ports/transwarp/portfile.cmake Outdated Show resolved Hide resolved
versions/t-/transwarp.json Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 26, 2021
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR!

@ras0219-msft ras0219-msft merged commit ab9e4a2 into microsoft:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants