-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[transwarp] add a new port #18069
Merged
Merged
[transwarp] add a new port #18069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyue
force-pushed
the
feature/transwarp-port
branch
from
May 23, 2021 00:39
d270706
to
a3069cb
Compare
Hi there, I find there is one check failed, saying file's SHA on x86_windows's is incorrect.
I did run |
JackBoosY
added
the
category:new-port
The issue is requesting a new library to be added; consider making a PR!
label
May 24, 2021
JackBoosY
suggested changes
May 24, 2021
niyue
force-pushed
the
feature/transwarp-port
branch
from
May 24, 2021 08:29
a3069cb
to
76db81b
Compare
…task concurrency.
niyue
force-pushed
the
feature/transwarp-port
branch
from
May 24, 2021 08:44
76db81b
to
10d562d
Compare
JackBoosY
suggested changes
May 24, 2021
JackBoosY
suggested changes
May 24, 2021
JackBoosY
approved these changes
May 24, 2021
JackBoosY
suggested changes
May 25, 2021
JackBoosY
suggested changes
May 25, 2021
JackBoosY
approved these changes
May 26, 2021
LGTM, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:new-port
The issue is requesting a new library to be added; consider making a PR!
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Add a new port called transwarp, a header-only C++ library for task concurrency
Related transwarp issue:
Add transwarp to vcpkg repo bloomen/transwarp#26
Which triplets are supported/not supported? Have you updated the CI baseline?
all, NO
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes