Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openh264] fixup the installed pkgconfig files #18077

Merged
merged 3 commits into from
May 24, 2021

Conversation

mcmtroffaes
Copy link
Contributor

  • What does your PR fix?

    The openh264 port current writes a .pc file containing a prefix to an absolute path to its packages folder. This patch fixes this.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No changes.

  • Does your PR follow the maintainer guide?

    Yes, to the best of my knowledge.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label May 24, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 24, 2021
@ras0219-msft ras0219-msft merged commit e937cb4 into microsoft:master May 24, 2021
@ras0219-msft
Copy link
Contributor

Thanks!

@mcmtroffaes mcmtroffaes deleted the feature/openh264-pkgconf branch May 24, 2021 18:30
@mcmtroffaes
Copy link
Contributor Author

You're welcome - many thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants