Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xmlsec]Update to 1.2.32 #18199

Merged
merged 4 commits into from
Jun 3, 2021
Merged

Conversation

SvenPStarFinanz
Copy link
Contributor

  • What does your PR fix?

Updates xmlsec to 1.2.32. Among other minor fixes that version removes the need to patch UWP build.

  • Which triplets are supported/not supported? Have you updated the [CI baseline]

no change

  • Does your PR follow the [maintainer guide]

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@JonLiu1993 JonLiu1993 self-assigned this May 31, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 31, 2021
ports/xmlsec/vcpkg.json Outdated Show resolved Hide resolved
versions/x-/xmlsec.json Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 changed the title Update xmlsec to 1.2.32 [xmlsec]Update to 1.2.32 May 31, 2021
Fixing bug on Windows build, xmlsec persists on lib prefix for the dll file.
@SvenPStarFinanz
Copy link
Contributor Author

Apart from the version update I found/fixed a problem resulted by #16908 on Windows build of xmlsec. In src\dl.c of xmlsec there was constructed the name of the crypto library, which always have to begin with "lib", so I turned back to the old file name on Windows.

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 1, 2021
@ras0219-msft ras0219-msft merged commit b121bba into microsoft:master Jun 3, 2021
@ras0219-msft
Copy link
Contributor

That makes sense to me, thanks for the update & fix!

@SvenPStarFinanz SvenPStarFinanz deleted the xmlsec_1.2.32 branch June 4, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants