-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google-cloud-cpp] update to latest (v1.28.0) version #18246
[google-cloud-cpp] update to latest (v1.28.0) version #18246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coryan ,Thanks for your pr,please add 'vcpkg_fixup_pkgconfig()' below '
vcpkg_fixup_cmake_targets(CONFIG_PATH lib/cmake TARGET_PATH share)
in portfile.cmake
Done, please take another look. |
It looks like the grpc pkgconfig files are not fixed up; we'll need to add similar commands to that and abseil before google-cloud-cpp will be able to properly support pkgconfig. |
This reverts commit db47320.
Ugh. I have reverted the |
Thanks a bunch; I think doing all three at the same time would be small enough to be put into a single PR, but separate is definitely the "proper" solution :) |
What does your PR fix?
N/A. It updates
google-cloud-cpp
to the latest release (v1.28.0). One of the new things in this release is the-DGOOGLE_CLOUD_CPP_ENABLE_EXAMPLES=OFF
option, which eliminates the need fordisable-benchmarks.patch
.Which triplets are supported/not supported? Have you updated the CI baseline?
No change.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes.