Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[utfcpp] Update to 3.2.1 version #18299

Merged
merged 2 commits into from
Jun 11, 2021
Merged

[utfcpp] Update to 3.2.1 version #18299

merged 2 commits into from
Jun 11, 2021

Conversation

RT2Code
Copy link
Contributor

@RT2Code RT2Code commented Jun 6, 2021

@JonLiu1993 JonLiu1993 self-assigned this Jun 7, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 7, 2021
JonLiu1993
JonLiu1993 reviewed Jun 7, 2021
View reviewed changes
Copy link
Member

@JonLiu1993 JonLiu1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RT222 ,Thanks for your PR.could you explain why the patch was deleted?

@JonLiu1993 JonLiu1993 added info:good-first-issue This issue would be a good issue to get one's feet wet in solving. requires:author-response and removed info:good-first-issue This issue would be a good issue to get one's feet wet in solving. labels Jun 7, 2021
@RT2Code
Copy link
Contributor Author

RT2Code commented Jun 7, 2021

Utfcpp was providing GTest as a submodule, and the patch used the vcpkg port instead to build the library. Since the 3.2 version, the author switched from GTest to his own unit test framework, rendering this patch obsolete : nemtrif/utfcpp@fe79d14

@JonLiu1993
Copy link
Member

Utfcpp was providing GTest as a submodule, and the patch used the vcpkg port instead to build the library. Since the 3.2 version, the author switched from GTest to his own unit test framework, rendering this patch obsolete : nemtrif/utfcpp@fe79d14

Thanks for your clarification

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 7, 2021
@strega-nil-ms
Copy link
Contributor

Cool, thanks @RT222 :)

@strega-nil-ms strega-nil-ms merged commit b7644f0 into microsoft:master Jun 11, 2021
@RT2Code RT2Code deleted the utfcpp branch June 11, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RT2Code @JonLiu1993 @strega-nil-ms