Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[approval-tests-cpp] New port #18338

Merged
merged 2 commits into from
Jun 11, 2021
Merged

[approval-tests-cpp] New port #18338

merged 2 commits into from
Jun 11, 2021

Conversation

claremacrae
Copy link
Contributor

Co-Authored-By: nicole mazzuca [email protected]

Add port for ApprovalTests.cpp - https://github.com/approvals/ApprovalTests.cpp

@ghost
Copy link

ghost commented Jun 8, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 self-assigned this Jun 9, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 9, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 9, 2021
@Pospelove
Copy link
Contributor

Thanks for working on this port!

@strega-nil-ms
Copy link
Contributor

Thanks for working with me on this @claremacrae :)

@strega-nil-ms strega-nil-ms merged commit b5f8ec7 into microsoft:master Jun 11, 2021
@claremacrae
Copy link
Contributor Author

Thanks for the help @strega-nil - and the quick merge!

@claremacrae claremacrae mentioned this pull request Jun 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] ApprovalTests.cpp
5 participants
@claremacrae @Pospelove @strega-nil-ms @ras0219 @JonLiu1993