[vcpkg_download_distfile] Fix regression for downloading via ARIA2 and downloading with HTTP headers #18340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
force-pushed
the
dev/roschuma/headers
branch
from
f589e2a
to
8cfcb55
Compare
JackBoosY
added
category:vcpkg-bug
JackBoosY
approved these changes
Jun 9, 2021
|
Maybe fix #18291. |
Neumann-A
reviewed
Jun 9, 2021
|
works for me. just missing a test_hash in the aria path |
ras0219-msft
force-pushed
the
dev/roschuma/headers
branch
from
8cfcb55
to
5fca10a
Compare
strega-nil
approved these changes
Jun 9, 2021
vicroms
approved these changes
Jun 9, 2021
|
All the failures are download failures, so I'm fine merging. Thanks robert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.