Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boost-modular-build-helper] Fix boost build toolchain options not being used #18529

Merged
merged 2 commits into from
Jul 6, 2021
Merged

[boost-modular-build-helper] Fix boost build toolchain options not being used #18529

merged 2 commits into from
Jul 6, 2021

Commits on Jun 21, 2021

  1. Fix boost build toolchain options not being used 

    The issue was due to the options only being set for the gcc toolchain,
and then only for a specific version. On platforms defaulting to a
different toolchain (e.g. macOS) this didn't work at all.

Additionally, some missing flags were not propagated, in particular the
CMAKE_OSX_DEPLOYMENT_TARGET, CMAKE_OSX_SYSROOT and CMAKE_OSX_ARCHITECTURES
    @martijn-resolume
    Martijn Otto authored and martijn-resolume committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    1534065 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. [boost-modular-build-helper] Apply CR comments

    @ras0219
    ras0219 committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    8de63e4 View commit details
    Browse the repository at this point in the history