[apsi] Add new port

[WeiDaiWD]

Describe the pull request

• What does your PR fix?

  Added a new port: apsi.

• Which triplets are supported/not supported? Have you updated the CI baseline?

  all static, No

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[WeiDaiWD]

Feature "hexl" requires x64. I don't know how to handle that in an upstream port, "apsi".

"apsi" only supports static build.

[NancyLi1013]

Feature "hexl" requires x64. I don't know how to handle that in an upstream port, "apsi".

"apsi" only supports static build.

You can add platform for feature hexl in vcpkg.json and add unsupported message in portfile.cmake.

if("hexl" IN_LIST FEATURES)
    ....
endif()

[WeiDaiWD]

Feature "hexl" requires x64. I don't know how to handle that in an upstream port, "apsi".
"apsi" only supports static build.

You can add platform for feature hexl in vcpkg.json and add unsupported message in portfile.cmake.

if("hexl" IN_LIST FEATURES)
    ....
endif()

Since "hexl" itself detects architecture and fails installation if not "x64", do I need to add this detection in ports/apsi/portfile.cmake?

[WeiDaiWD]

That failure looks weird to me. Shall we rerun failed tests?

[NancyLi1013]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[WeiDaiWD]

Cool! Let me know if more changes are needed. Thanks!

[NancyLi1013]

LGTM, except for the feature hexl. Seems you only added other two features, hexl is not handled in portfile.cmake.

Just mentioned, have you tested the feature hexl? Since other features are default features, it's not necessary to test them again.

[NancyLi1013]

LGTM now, thanks for adding this new port. @WeiDaiWD

[NancyLi1013]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[WeiDaiWD]

Not meaning to push the process, I wonder if there is anything that I need to do. Thanks!

[NancyLi1013]

Not meaning to push the process, I wonder if there is anything that I need to do. Thanks!

Just wait for the process to merge. Nothing else needs to be done on your sides now.