-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ompl] Fix linking using ${OMPL_LIBRARIES} #18908
Conversation
LGTM, thanks for your fixing @Ace314159. |
Actually, ompl has the following issue:
|
Sorry for the delay. I'm not that familiar with the cmake targets, so I'm not sure if I did it correctly, but do these changes address the issues? |
The failures with static seem to be because I'm not sure how to fix this. Do you have any suggestions? |
I was able to fix the build issues. Does everything look good now? |
Others LGTM. |
Co-authored-by: Phoebe <[email protected]>
Co-authored-by: Phoebe <[email protected]>
Describe the pull request
What does your PR fix?
Fixes [ompl] Cannot find lib files when using CMake #18237
Which triplets are supported/not supported? Have you updated the CI baseline?
all, Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/