Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libidn2] Fixes for mingw and minor issues #19002

Merged
merged 9 commits into from
Jul 26, 2021
Merged

[libidn2] Fixes for mingw and minor issues #19002

merged 9 commits into from
Jul 26, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 19, 2021 •
edited
Loading

  • What does your PR fix?

    • Fixes building with mingw (needed for curl). For faster build, it uses the cmake build system which is also used for MSVC.
    • Installs the pc file also for cmake builds.
    • Modernizes the portfile
    • Use libunistring for non-windows

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes, but I am still working on this PR.

@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 19, 2021
@dg0yt dg0yt mentioned this pull request Jul 20, 2021
Merged
8 tasks
@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 22, 2021

I can pick up libunistring in another PR. But this one is needed for updating curl.

@dg0yt dg0yt marked this pull request as ready for review July 22, 2021 06:11
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 26, 2021
@vicroms vicroms merged commit b57e29a into microsoft:master Jul 26, 2021
@dg0yt dg0yt deleted the libidn2 branch July 29, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @NancyLi1013 @vicroms