Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protobuf] add support for mingw subsystem #19054

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

fairlyblank
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    protobuf build for mingw subsystem. no issue.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 22, 2021
@PhoebeHui
Copy link
Contributor

@fairlyblank, could you update the baseline version via './vcpkg x-add-version --overwrite-version protobuf' and submit the changes again?

@fairlyblank
Copy link
Contributor Author

@fairlyblank, could you update the baseline version via './vcpkg x-add-version --overwrite-version protobuf' and submit the changes again?

I think i have updated the git-tree in last commit, after 'git rev-parse HEAD:ports/protubuf' .
I have run './vcpkg x-add-version --overwrite-version protobuf', but nothing need to commit.
Something i'm doing wrong here?

@PhoebeHui
Copy link
Contributor

@fairlyblank, you didn't update the port-version in vcpkg.json, so it failed, I have updated it and committed the changes.

@fairlyblank
Copy link
Contributor Author

@fairlyblank, you didn't update the port-version in vcpkg.json, so it failed, I have updated it and committed the changes.

I missed that, thanks for your time.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 29, 2021
@dan-shaw dan-shaw merged commit a863c84 into microsoft:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants