Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arrow] Update to 5.0.0 #19229

Merged
merged 12 commits into from
Aug 5, 2021
Merged

[arrow] Update to 5.0.0 #19229

merged 12 commits into from
Aug 5, 2021

Conversation

ianmcook
Copy link
Contributor

Updates the arrow port to version 5.0.0

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 8dddc6c899ce6fdbeab38b525a31e7f23cb2d5bb -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/arrow.json b/versions/a-/arrow.json
index c8b33d9..64528d5 100644
--- a/versions/a-/arrow.json
+++ b/versions/a-/arrow.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "244420f209fd8afcc5f2fd1cc9c536060e75d63a",
+      "git-tree": "53971762b449ee0936e101ef0de0681586664045",
       "version": "5.0.0",
       "port-version": 0
     },

@ianmcook
Copy link
Contributor Author

The CI failure is happening because tensorflow-cc is not building. I believe this is unrelated to arrow. tensorflow-cc requires Bazel 3.99.0 or lower and this vcpkg commit on July 22 updated Bazel to 4.1.0: 16aeda9#diff-151d9ba93b4be2dfa98ec4f962bd066169262d77d1ae72b256db570329f7d898R399

I opened #19235 for this.

I will add tensorflow-cc:x64-windows-static=fail to scripts\ci.baseline.txt.

@ianmcook ianmcook marked this pull request as ready for review July 29, 2021 21:39
@ianmcook
Copy link
Contributor Author

@GPSnoopy please let me know if you encounter any issues updating ParquetSharp to Arrow 5.0.0

@JonLiu1993 JonLiu1993 self-assigned this Jul 30, 2021
@PhoebeHui
Copy link
Contributor

The tensorflow failures would be fixed by PR #19165

@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Jul 30, 2021
@JonLiu1993
Copy link
Member

@ianmcook ,Have you tested the feature locally?

@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jul 30, 2021
@GPSnoopy
Copy link
Contributor

@ianmcook, all green for me: G-Research/ParquetSharp#214

@ianmcook
Copy link
Contributor Author

@ianmcook ,Have you tested the feature locally?

Yes, I tested most of the non-default features locally by running both of these:

./vcpkg install arrow[dataset,mimalloc,orc,s3]:x64-windows --recurse
./vcpkg install arrow[dataset,mimalloc,orc,s3]:x64-windows-static --recurse

The jemalloc feature is only relevant for non-Windows environments, and the flight feature of the arrow port is currently experimental and known to have build problems, so I did not test those locally.

@JonLiu1993 JonLiu1993 removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Aug 2, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 2, 2021
@dan-shaw
Copy link
Contributor

dan-shaw commented Aug 4, 2021

The tensorflow baseline failure should have been fixed by #19165. Can we remove the baseline update?

@ianmcook
Copy link
Contributor Author

ianmcook commented Aug 4, 2021

The tensorflow baseline failure should have been fixed by #19165. Can we remove the baseline update?

Removed in 478864e

@dan-shaw dan-shaw merged commit ba69c09 into microsoft:master Aug 5, 2021
GPSnoopy added a commit to G-Research/ParquetSharp that referenced this pull request Aug 9, 2021
GPSnoopy added a commit to G-Research/ParquetSharp that referenced this pull request Sep 2, 2021
* Update to Arrow-5.0.0

* Review enums.
Review Resharper warnings (fix memory leak in ColumPath).

* Fix unit tests (schema version).

* Point to arrow-5.0.0 PR merge on vcpkg master

microsoft/vcpkg#19229

* Bump version to 5.0.0-beta1

* Fix format error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants