[harfbuzz] Don't make use of IN_LIST

[daschuer]

• What does your PR fix?

This fixes compatibility issues with Policy CMP0057
In projects where CMP0057 is not set you receive:

CMake Warning (dev) at /Users/runner/mixxx-vcpkg/installed/x64-osx-mixxx/share/harfbuzz/harfbuzzConfig.cmake:28 (if):
  Policy CMP0057 is not set: Support new IN_LIST if() operator.  Run "cmake
  --help-policy CMP0057" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  IN_LIST will be interpreted as an operator when the policy is set to NEW.
  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  /Users/runner/mixxx-vcpkg/scripts/buildsystems/vcpkg.cmake:782 (_find_package)
  /Users/runner/mixxx-vcpkg/installed/x64-osx-mixxx/share/qt5core/vcpkg-cmake-wrapper.cmake:22 (find_package)
  /Users/runner/mixxx-vcpkg/scripts/buildsystems/vcpkg.cmake:736 (include)
  cmake/Modules/ECMQueryQmake.cmake:1 (find_package)
  cmake/Modules/ECMGeneratePriFile.cmake:83 (include)
  CMakeLists.txt:18 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error at /Users/runner/mixxx-vcpkg/installed/x64-osx-mixxx/share/harfbuzz/harfbuzzConfig.cmake:28 (if):
  if given arguments:

    "graphite2" "IN_LIST" "HARFBUZZ_FEATURES"

• Which triplets are supported/not supported? Have you updated the CI baseline?

  Unchanged

• Does your PR follow the maintainer guide?

  yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 57bd7102d9fd880daa1b0958692294c4a125f6d8 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/h-/harfbuzz.json b/versions/h-/harfbuzz.json
index 0a578bd..2a040e8 100644
--- a/versions/h-/harfbuzz.json
+++ b/versions/h-/harfbuzz.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "aa38e73b941deaa4ffd19cda8ecbe0a143a5a7fa",
+      "git-tree": "f02430ff3435ae9db60d3064dbf740cfbb20dddc",
       "version": "2.8.1",
       "port-version": 1
     },

[Neumann-A]

What is the cmake_minimum_required in the project giving the error? IN_LIST exists since cmake 3.3. As such setting the policy to NEW is the more appropriate fix.

[dg0yt]

Please note:

• portfile.cmake is run by vcpkg with CMake 3.20 or newer. IN_LIST can be safely used here. No changes required.
• Exported config files and wrappers might run in older versions of CMake. vcpkg claims to support CMake 3.1 in some cases, but the truth is that the toolchain scripts use CMake 3.4 features. Switching to CMake 3.5 is proposed.
  In the meantime I would second the opinion that the config.cmake patch should use the policy which is needed to allow IN_LIST.

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for harfbuzz but no changes to version or port version.
-- Version: 2.8.1
-- Old SHA: 32e5438e1f8c76646b657f14fbe0dac7646d80f6
-- New SHA: 0f52a589f83e19a5cc3ff6a3bcb4ad0c87b78cbf
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 57bd7102d9fd880daa1b0958692294c4a125f6d8 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/h-/harfbuzz.json b/versions/h-/harfbuzz.json
index 2e37d64..66f3d1e 100644
--- a/versions/h-/harfbuzz.json
+++ b/versions/h-/harfbuzz.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "0f52a589f83e19a5cc3ff6a3bcb4ad0c87b78cbf",
+      "git-tree": "32e5438e1f8c76646b657f14fbe0dac7646d80f6",
       "version": "2.8.1",
       "port-version": 0
     },

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 57bd7102d9fd880daa1b0958692294c4a125f6d8 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/h-/harfbuzz.json b/versions/h-/harfbuzz.json
index 809f6da..698b0de 100644
--- a/versions/h-/harfbuzz.json
+++ b/versions/h-/harfbuzz.json
@@ -6,7 +6,7 @@
       "port-version": 1
     },
     {
-      "git-tree": "0f52a589f83e19a5cc3ff6a3bcb4ad0c87b78cbf",
+      "git-tree": "32e5438e1f8c76646b657f14fbe0dac7646d80f6",
       "version": "2.8.1",
       "port-version": 0
     },

[daschuer]

OK lets give this a try.

[daschuer]

I can confirm that this fixes the issue.