[vcpkg] The FreeBSD spelling of x86-64 is amd64. #19456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_HOST_SYSTEM_PROCESSOR is set to amd64 on x86-64 FreeBSD systems. CMake's STREQUAL gives a case-sensitive comparison so this case was missed during bootstrapping when using vcpkg as a submodule.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PhoebeHui
changed the title
PhoebeHui
approved these changes
Aug 10, 2021
PhoebeHui
added
category:tool-update
|
@davidchisnall, thanks for your PR! |
|
Thanks for your contribution! |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Aug 12, 2021
The FreeBSD spelling of x86-64 is amd64. (microsoft#19456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
CMAKE_HOST_SYSTEM_PROCESSORis set to amd64 on x86-64 FreeBSD systems. CMake'sSTREQUALgives a case-sensitive comparison so this case was missed during bootstrapping when using vcpkg as a submodule.What does your PR fix?
Bootstrapping via including the toolchain file on FreeBSD.
Which triplets are supported/not supported? Have you updated the [CI baseline]
x64-freebsd. It may affect other community triplets where the system provides the same
uname -moutput as FreeBSD.Does your PR follow the maintainer guide?
Yes, as far as I can tell.