Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[value-ptr-lite] Fix usage #19457

Merged
merged 3 commits into from
Aug 9, 2021
Merged

[value-ptr-lite] Fix usage #19457

merged 3 commits into from
Aug 9, 2021

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Fix package name in usage.

Now the usage is like this:

    find_package(value_ptr-lite CONFIG REQUIRED)
    target_link_libraries(main PRIVATE nonstd::value_ptr-lite)

Note: Feature test has passed with the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 9, 2021
@NancyLi1013 NancyLi1013 mentioned this pull request Aug 9, 2021
Closed
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 9, 2021
@dan-shaw dan-shaw merged commit 3d4c4cb into microsoft:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[value-ptr-lite] Package config naming differs from package name
3 participants
@NancyLi1013 @JackBoosY @dan-shaw