-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bshoshany-thread-pool] add a new port (1.9) #19470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout cf03dac5c25dd5a8d207d0b7d546f24424898418 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8f49caf..50d48cd 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1077,8 +1077,8 @@
"port-version": 0
},
"bshoshany-thread-pool": {
- "baseline":"1.9",
- "port-version":0
+ "baseline": "1.9",
+ "port-version": 0
},
"bsio": {
"baseline": "1.0.0",
Co-authored-by: JonLiu1993 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for bshoshany-thread-pool but no changes to version or port version.
-- Version: 1.9
-- Old SHA: 18daeb735c0d78ebba1fde4ae54b0a6ead8b6b7b
-- New SHA: 3bf25aeda80f24f60e211ac4f04483b97d59cadf
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Co-authored-by: JonLiu1993 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for bshoshany-thread-pool but no changes to version or port version.
-- Version: 1.9
-- Old SHA: 18daeb735c0d78ebba1fde4ae54b0a6ead8b6b7b
-- New SHA: 4ec35ab1086df444d30b05ff49cf2a66c21ebd52
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
What does your PR fix?
Adds a new port for https://github.com/bshoshany/thread-pool
Which triplets are supported/not supported? Have you updated the CI baseline?
Any platform that supports c++17 (header file only). Baseline updated.
Does your PR follow the maintainer guide?
AFAIK Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes