[rsm-bsa] new port #19496

Guekka · 2021-08-11T10:14:09Z

Add port for the BSA library

What does your PR fix?

Add new port. No one requested it

Which triplets are supported/not supported? Have you updated the CI baseline?

Supported triplets are x64 & (windows | linux) & static

Yes, CI updated

Does your PR follow the maintainer guide?

I think so

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

ghost · 2021-08-11T10:14:21Z

All CLA requirements met.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 69478c5caafcde4c490bb1fccb960296801dbb5f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index ecae6d2..75b776d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1076,6 +1076,10 @@
       "baseline": "1.11.0",
       "port-version": 0
     },
+    "bsa": {
+      "baseline": "2.0.2",
+      "port-version": 0
+    },
     "bsio": {
       "baseline": "1.0.0",
       "port-version": 0

scripts/ci.baseline.txt

JonLiu1993 · 2021-08-12T09:42:14Z

Could you please resolve the conflicts against master?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 63aa65e65b9d2c08772ea15d25fb8fdb0d32e557 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index d3bd6d2..2a57c63 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1076,14 +1076,14 @@
       "baseline": "1.11.0",
       "port-version": 0
     },
-    "bshoshany-thread-pool": {
-      "baseline": "1.9",
-	   port-version : 0
-	},
     "bsa": {
       "baseline": "2.0.2",
       "port-version": 0
     },
+    "bshoshany-thread-pool": {
+      "baseline": "1.9",
+      "port-version": 0
+    },
     "bsio": {
       "baseline": "1.0.0",
       "port-version": 0

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 63aa65e65b9d2c08772ea15d25fb8fdb0d32e557 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 0af07c5..2a57c63 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1076,14 +1076,14 @@
       "baseline": "1.11.0",
       "port-version": 0
     },
-    "bshoshany-thread-pool": {
-      "baseline": "1.9",
-      "port-version": 0
-	},
     "bsa": {
       "baseline": "2.0.2",
       "port-version": 0
     },
+    "bshoshany-thread-pool": {
+      "baseline": "1.9",
+      "port-version": 0
+    },
     "bsio": {
       "baseline": "1.0.0",
       "port-version": 0

scripts/ci.baseline.txt

versions/b-/bsa.json

Co-authored-by: JonLiu1993 <[email protected]>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for rsm-bsa but no changes to version or port version.
-- Version: 2.0.3
-- Old SHA: 59e8dee0afa59f367aed7653be1ac7c4bca6d138
-- New SHA: 465b19a5d463c1a9b54041b30600599ad0d5ac96
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

JonLiu1993 · 2021-09-10T11:37:01Z

@Guekka ，Could you please take a look?

[3/6] /usr/bin/c++  -I/mnt/vcpkg-ci/buildtrees/rsm-bsa/src/2.0.3-80256db965.clean/src/../include -I/mnt/vcpkg-ci/buildtrees/rsm-bsa/src/2.0.3-80256db965.clean/src/../src -isystem /mnt/vcpkg-ci/installed/x64-linux/include -fPIC -g -fvisibility=hidden -std=c++2a -MD -MT src/CMakeFiles/bsa.dir/bsa/tes3.cpp.o -MF src/CMakeFiles/bsa.dir/bsa/tes3.cpp.o.d -o src/CMakeFiles/bsa.dir/bsa/tes3.cpp.o -c /mnt/vcpkg-ci/buildtrees/rsm-bsa/src/2.0.3-80256db965.clean/src/bsa/tes3.cpp
FAILED: src/CMakeFiles/bsa.dir/bsa/tes3.cpp.o 
/usr/bin/c++  -I/mnt/vcpkg-ci/buildtrees/rsm-bsa/src/2.0.3-80256db965.clean/src/../include -I/mnt/vcpkg-ci/buildtrees/rsm-bsa/src/2.0.3-80256db965.clean/src/../src -isystem /mnt/vcpkg-ci/installed/x64-linux/include -fPIC -g -fvisibility=hidden -std=c++2a -MD -MT src/CMakeFiles/bsa.dir/bsa/tes3.cpp.o -MF src/CMakeFiles/bsa.dir/bsa/tes3.cpp.o.d -o src/CMakeFiles/bsa.dir/bsa/tes3.cpp.o -c /mnt/vcpkg-ci/buildtrees/rsm-bsa/src/2.0.3-80256db965.clean/src/bsa/tes3.cpp
In file included from /mnt/vcpkg-ci/buildtrees/rsm-bsa/src/2.0.3-80256db965.clean/src/bsa/tes3.cpp:1:
/mnt/vcpkg-ci/buildtrees/rsm-bsa/src/2.0.3-80256db965.clean/src/../include/bsa/tes3.hpp:3:10: fatal error: compare: No such file or directory
    3 | #include <compare>
      |          ^~~~~~~~~
compilation terminated.

Guekka · 2021-09-10T16:37:39Z

@JonLiu1993

I already answered, actually. But I answered in a resolved conversation, so I guess you didn't get notified
As I've said previously, this port fails to build in CI because the GCC version is too old. I wanted to change ci_baseline to skip the Linux port, but you told me to remove Linux support instead
And @ras0219-msft made me change the support line again, adding back Linux

Sorry if I'm not clear. Basically, I'm asking whether I should :

Change ci_baseline because it will work fine on people computers
Remove Linux in support, even though the library supports Linux

JackBoosY · 2021-09-13T08:57:02Z

We should not limit the user's gcc version, so the solution is as follows:

When VCPKG_TARGET_IS_LINUX is ON in portfile.cmake, use a message to warn users of the minimum gcc version required.
Add rsm-bsa:x64-linux=skip in scripts/ci.baseline.txt and write a related comment.

Guekka · 2021-09-13T16:16:32Z

CI seems to work. Should I clean up the history?

JackBoosY · 2021-09-14T02:16:32Z

@Guekka Please implement the first one of my suggestions.

Guekka · 2021-09-14T07:41:34Z

@JackBoosY It has already been done in a previous commit
https://github.com/microsoft/vcpkg/pull/19496/files#diff-a16b669525fbc4d2650edeab0694190928c6582021f972a4cdf123ee12e22ec0R11-R13

…+10.

BillyONeal · 2021-09-14T21:35:15Z

Sorry for the confusion, I thought our VMs had Ubuntu 20.10 which has GCC 10.3 but they actually have 20.04 which is GCC 9.x.

… have G++10." because we actually are on gcc 9.x :( This reverts commit 781289d.

BillyONeal · 2021-09-14T22:02:34Z

Thanks for the new port :)

JonLiu1993 self-assigned this Aug 11, 2021

JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 11, 2021

github-actions bot requested changes Aug 11, 2021

View reviewed changes

github-actions bot approved these changes Aug 12, 2021

View reviewed changes

JonLiu1993 reviewed Aug 12, 2021

View reviewed changes

scripts/ci.baseline.txt Outdated Show resolved Hide resolved

JonLiu1993 added the requires:author-response label Aug 12, 2021

Guekka added 3 commits August 12, 2021 11:41

[bsa] new port

7eeba23

[bsa] Update version file

0142e8c

[bsa] Update ci baseline

0fa7d22

Guekka added 5 commits August 12, 2021 11:43

[bsa] Update version database

f7a9269

[bsa] Add patch for minimum cmake version

8082b43

[bsa] Update ci baseline

dd41d4f

Update version database

3b398fc

Try more CI

b8b3f03

github-actions bot requested changes Aug 12, 2021

View reviewed changes

Guekka marked this pull request as draft August 12, 2021 09:53

Fix merge typo

05ad950

JonLiu1993 removed the requires:author-response label Aug 12, 2021

github-actions bot requested changes Aug 12, 2021

View reviewed changes

Guekka added 2 commits August 12, 2021 12:03

[bsa] Update library version

2b495aa

Update versions database

789c35b

github-actions bot approved these changes Aug 12, 2021

View reviewed changes

JonLiu1993 requested changes Aug 12, 2021

View reviewed changes

scripts/ci.baseline.txt Outdated Show resolved Hide resolved

scripts/ci.baseline.txt Outdated Show resolved Hide resolved

JonLiu1993 requested changes Aug 12, 2021

View reviewed changes

versions/b-/bsa.json Outdated Show resolved Hide resolved

Guekka and others added 2 commits August 12, 2021 10:20

Apply suggestions from code review

b58c420

Co-authored-by: JonLiu1993 <[email protected]>

Update versions/b-/bsa.json

ce3bc5c

Co-authored-by: JonLiu1993 <[email protected]>

Guekka marked this pull request as ready for review August 12, 2021 10:43

github-actions bot approved these changes Aug 13, 2021

View reviewed changes

Fix typo

b076e80

github-actions bot requested changes Aug 31, 2021

View reviewed changes

Update versions

19f8be0

github-actions bot approved these changes Aug 31, 2021

View reviewed changes

Guekka requested a review from ras0219-msft August 31, 2021 17:40

JackBoosY self-assigned this Sep 13, 2021

JackBoosY removed the requires:author-response label Sep 13, 2021

JackBoosY added the requires:author-response label Sep 13, 2021

Update ci.baseline.txt

7fd009e

github-actions bot approved these changes Sep 13, 2021

View reviewed changes

JonLiu1993 removed the requires:author-response label Sep 14, 2021

JonLiu1993 added the requires:author-response label Sep 14, 2021

JackBoosY removed the requires:author-response label Sep 14, 2021

JackBoosY approved these changes Sep 14, 2021

View reviewed changes

JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 14, 2021

BillyONeal added 2 commits September 14, 2021 14:29

Merge remote-tracking branch 'origin/master' into HEAD

dd67f7e

Remove rsm-bsa:x64-linux=fail in ci.baseline.txt now that VMs have G+…

781289d

…+10.

github-actions bot approved these changes Sep 14, 2021

View reviewed changes

Revert "Remove rsm-bsa:x64-linux=fail in ci.baseline.txt now that VMs…

1091da1

… have G++10." because we actually are on gcc 9.x :( This reverts commit 781289d.

github-actions bot approved these changes Sep 14, 2021

View reviewed changes

BillyONeal merged commit 583ce28 into microsoft:master Sep 14, 2021

Ryan-rsm-McKenzie mentioned this pull request Nov 9, 2021

[rsm-bsa] Update to 4.0.0 #21214

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rsm-bsa] new port #19496

[rsm-bsa] new port #19496

Guekka commented Aug 11, 2021

ghost commented Aug 11, 2021 •

edited by ghost

Loading

github-actions bot left a comment

JonLiu1993 commented Aug 12, 2021

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

JonLiu1993 commented Sep 10, 2021

Guekka commented Sep 10, 2021

JackBoosY commented Sep 13, 2021

Guekka commented Sep 13, 2021

JackBoosY commented Sep 14, 2021

Guekka commented Sep 14, 2021

BillyONeal commented Sep 14, 2021

BillyONeal commented Sep 14, 2021

[rsm-bsa] new port #19496

[rsm-bsa] new port #19496

Conversation

Guekka commented Aug 11, 2021

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

ghost commented Aug 11, 2021 • edited by ghost Loading

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Aug 12, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Sep 10, 2021

Guekka commented Sep 10, 2021

JackBoosY commented Sep 13, 2021

Guekka commented Sep 13, 2021

JackBoosY commented Sep 14, 2021

Guekka commented Sep 14, 2021

BillyONeal commented Sep 14, 2021

BillyONeal commented Sep 14, 2021

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

ghost commented Aug 11, 2021 •

edited by ghost

Loading