Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Document deprecated functions from #20142 in the maintainer guide. #20217

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

BillyONeal
Copy link
Member

See discussion at #20142 (comment)

@BillyONeal BillyONeal added category:documentation To resolve the issue, documentation will need to be updated info:internal This PR or Issue was filed by the vcpkg team. labels Sep 17, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/openimageio/portfile.cmake

@PhoebeHui PhoebeHui self-assigned this Sep 17, 2021
@PhoebeHui PhoebeHui changed the title Document deprecated functions from #20142 in the maintainer guide. [docs] Document deprecated functions from #20142 in the maintainer guide. Sep 17, 2021
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 18, 2021
@Osyotr
Copy link
Contributor

Osyotr commented Sep 20, 2021

Would you kindly also update vcpkg-tool? It suggests to use deprecated vcpkg_fixup_cmake_targets
https://github.com/microsoft/vcpkg-tool/blob/733e90d1bc3f4f8188d57d73e2d20765c232cc26/src/vcpkg/postbuildlint.cpp#L265

@BillyONeal
Copy link
Member Author

Would you kindly also update vcpkg-tool? It suggests to use deprecated vcpkg_fixup_cmake_targets
https://github.com/microsoft/vcpkg-tool/blob/733e90d1bc3f4f8188d57d73e2d20765c232cc26/src/vcpkg/postbuildlint.cpp#L265

Done: microsoft/vcpkg-tool#198

@BillyONeal BillyONeal merged commit 53e3b41 into microsoft:master Sep 20, 2021
@BillyONeal BillyONeal deleted the document-deprecated-functions branch September 20, 2021 16:07
BillyONeal added a commit to microsoft/vcpkg-tool that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants