Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kf5diagram] new port #20234

Merged
merged 3 commits into from
Sep 22, 2021
Merged

[kf5diagram] new port #20234

merged 3 commits into from
Sep 22, 2021

Conversation

wrobelda
Copy link
Contributor

Describe the pull request
Adds new kf5diagram port.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All official, plus arm64-osx

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@wrobelda wrobelda marked this pull request as ready for review September 18, 2021 00:49
@JonLiu1993 JonLiu1993 self-assigned this Sep 18, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 18, 2021
@JonLiu1993
Copy link
Member

Depends on pr #20236

@JonLiu1993 JonLiu1993 added depends:upstream-changes Waiting on a change to the upstream project depends:different-pr This PR or Issue depends on a PR which has been filed and removed depends:upstream-changes Waiting on a change to the upstream project labels Sep 18, 2021
@wrobelda
Copy link
Contributor Author

@JonLiu1993 no longer has any dependencies.

@JonLiu1993 JonLiu1993 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 22, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 22, 2021
@strega-nil-ms
Copy link
Contributor

Thanks @wrobelda!

@strega-nil-ms strega-nil-ms merged commit 3083e1e into microsoft:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wrobelda @JonLiu1993 @strega-nil-ms @BillyONeal