Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s2n] update to 1.1.0 #20277

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

camarois
Copy link

Update port to latest version 1.1.0.
Also Debug target was pointing to release lib location. Cleaned the portfile and used vcpkg_cmake_config_fixup() instead to generate good debug/release targets.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/s2n/vcpkg.json b/ports/s2n/vcpkg.json
index 0b62164..4ee7f70 100644
--- a/ports/s2n/vcpkg.json
+++ b/ports/s2n/vcpkg.json
@@ -1,7 +1,6 @@
 {
   "name": "s2n",
   "version": "1.1.0",
-  "port-version": 0,
   "description": "C99 implementation of the TLS/SSL protocols.",
   "homepage": "https://github.com/aws/s2n-tls",
   "supports": "!uwp & !windows",
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 47d2378c8181ece05ffc51acd2ed60d97e3c9a64 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/s2n.json b/versions/s-/s2n.json
index 40377c6..1e0fd90 100644
--- a/versions/s-/s2n.json
+++ b/versions/s-/s2n.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "cad4f52e74ef1e63a889bf1e2ff61e048c6227a3",
+      "git-tree": "13b9d04cbee992cf866560de89551ceaf7dfc277",
       "version": "1.1.0",
       "port-version": 0
     },

@PhoebeHui PhoebeHui self-assigned this Sep 22, 2021
@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Sep 22, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your updates!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 22, 2021
@strega-nil-ms strega-nil-ms merged commit 729091b into microsoft:master Sep 22, 2021
@strega-nil-ms
Copy link
Contributor

Thanks @camarois!

@camarois camarois deleted the update-s2n-port branch October 19, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants