Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libmupdf] Update to 1.19.0-rc2 #20328

Merged
merged 8 commits into from
Nov 9, 2021
Merged

[libmupdf] Update to 1.19.0-rc2 #20328

merged 8 commits into from
Nov 9, 2021

Conversation

simon987
Copy link
Contributor

Describe the pull request

NOTE: I opened a ticket upstream for changes in writer.c (use-if-instead-of-ifdef-in-writer.patch) here

  • Which triplets are supported/not supported? Have you updated the CI baseline?

I have not updated the CI baseline

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@simon987 simon987 changed the title Update libmupdf to 1.19.0-rc2 [libmupdf] Update to 1.19.0-rc2 Sep 24, 2021
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 26, 2021
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the CMakeLists.txt could also be modified to use the harfbuzz cmake config. The current for of libary lookup misses the transitive usage requirements.

ports/libmupdf/CMakeLists.txt Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 59a3f35e7e5a3281e59863a4a0123c325899f8f9 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libmupdf.json b/versions/l-/libmupdf.json
index 1d3edd8..8b80b81 100644
--- a/versions/l-/libmupdf.json
+++ b/versions/l-/libmupdf.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "7ce0c78f2ac8620114d5f07ac4d3ac87533a7832",
+      "git-tree": "4f380902891197e6a7f0ebd178f5d0d06544d187",
       "version-string": "1.19.0-rc2",
       "port-version": 0
     },

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ports/libmupdf/portfile.cmake Outdated Show resolved Hide resolved
ports/libmupdf/vcpkg.json Show resolved Hide resolved
Co-authored-by: NancyLi1013 <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 33f02c0ae50c262da487d21ace4f5d67ae949c18 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libmupdf.json b/versions/l-/libmupdf.json
index 8b80b81..2c57f93 100644
--- a/versions/l-/libmupdf.json
+++ b/versions/l-/libmupdf.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "4f380902891197e6a7f0ebd178f5d0d06544d187",
+      "git-tree": "fdc6281a5e7f6d342c0fae903038d7c60afd5698",
       "version-string": "1.19.0-rc2",
       "port-version": 0
     },

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 33f02c0ae50c262da487d21ace4f5d67ae949c18 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libmupdf.json b/versions/l-/libmupdf.json
index 8b80b81..a900d9f 100644
--- a/versions/l-/libmupdf.json
+++ b/versions/l-/libmupdf.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "4f380902891197e6a7f0ebd178f5d0d06544d187",
+      "git-tree": "e91affc70edc5bab8dc75c274f14ba03b345c0bb",
       "version-string": "1.19.0-rc2",
       "port-version": 0
     },

@simon987
Copy link
Contributor Author

simon987 commented Nov 6, 2021

Okay @NancyLi1013 I pushed the proposed changes

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 8, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your updates. @simon987

@dan-shaw dan-shaw merged commit 6cfa934 into microsoft:master Nov 9, 2021
@simon987 simon987 mentioned this pull request Apr 13, 2023
7 tasks
@simon987 simon987 mentioned this pull request Jun 8, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libmupdf] Update to 1.19.0-rc2
4 participants