Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rsm-mmio] Add new port #20336

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Conversation

Ryan-rsm-McKenzie
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Adds a new port mmio

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Only supports Linux/Windows + static linkage

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@PhoebeHui PhoebeHui self-assigned this Sep 26, 2021
@PhoebeHui PhoebeHui added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Sep 26, 2021
@PhoebeHui
Copy link
Contributor

@Ryan-rsm-McKenzie, thanks for your PR!

Could you change the 'tab' to 'space' in portfile.cmake?

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 26, 2021
@BillyONeal BillyONeal merged commit 46e314d into microsoft:master Sep 28, 2021
@BillyONeal
Copy link
Member

Thanks for the port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants