[promise-cpp] Add new port

[chausner]

Describe the pull request

• What does your PR fix?

  Adds new port promise-cpp

• Which triplets are supported/not supported? Have you updated the CI baseline?

  All, Yes

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

[github-actions]

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for promise-cpp but no changes to version or port version.
-- Version: 1.0.3
-- Old SHA: fbd1822f72da4ff1934d6395ddd918d68f9c0c0a
-- New SHA: ef3fb5249eed37360ceb9b3b366037ad2ed2c865
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

[JonLiu1993]

This is error log:
install-x64-osx-dbg-out.log

[chausner]

I updated the port for the new major version 2.1.0 which was released yesterday. Unfortunately, the CMake install targets have apparently be removed from CMakeLists.txt so I now simply copy the headers into include.

The suggestion by vcpkg is not ideal, though:

The package promise-cpp is header only and can be used from CMake via:

find_path(PROMISE_CPP_INCLUDE_DIRS "add_ons.hpp")
target_include_directories(main PRIVATE ${PROMISE_CPP_INCLUDE_DIRS})

add_ons.hpp is not the primary header file. Is there any way to change what header file it recommends?

[dg0yt]

Is there any way to change what header file it recommends?

Add a usage file with the rectified usage instructions.

[chausner]

Is there any way to change what header file it recommends?

Add a usage file with the rectified usage instructions.

Thanks, added a usage file.

[BillyONeal]

I'm concerned that this port takes likely to conflict names:

• any.hpp
• add_ons.hpp
• call_traits.hpp

Would you consider it acceptable to install into a subidrectory like <promise-cpp/promise.hpp>?

[chausner]

Would you consider it acceptable to install into a subidrectory like <promise-cpp/promise.hpp>?

I noticed there is also another issue that is preventing the port from being usable right now: https://github.com/xhawk18/promise-cpp/blob/5e533a1c2beb363ca6b87f7f002007388349366c/include/promise.hpp#L262

I will open an issue and ask the maintainer if they can address these issues in the library itself so we don't have to work around them with patches.

[BillyONeal]

I noticed there is also another issue that is preventing the port from being usable right now: https://github.com/xhawk18/promise-cpp/blob/5e533a1c2beb363ca6b87f7f002007388349366c/include/promise.hpp#L262

Ouch! Best of luck!

[chausner]

@BillyONeal This should be ready now.

[PhoebeHui]

LGTM, thanks for your contribution!

[BillyONeal]

Thanks for running that down with upstream!