-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[directxtk, directxtk12, directxtex, directxmesh, uvatlas] ports updated for September 2021 release #20457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/directxmesh/portfile.cmake
ports/directxtex/portfile.cmake
ports/directxtk/portfile.cmake
ports/directxtk12/portfile.cmake
ports/uvatlas/portfile.cmake
A GitHub action told me to try out using the new I did, and for directxtk, directxtk12, and directxtex it fails using the new commands because my CMakeLists generates C headers via a custom_command that needs to be used for building:
I was able to use the new commands successfully for directxmesh, uvatlas which do not have embedded HLSL shaders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/directxtex/portfile.cmake
ports/directxtk/portfile.cmake
ports/directxtk12/portfile.cmake
If you need to generate files, better do that in the binary directory, not in the source directory. The new cmake maintainer functions use Ninja by default. And they build debug and release in parallel by default. This isn't compatible with modifying files in the source directory. |
This would break compatibility with all my vcxprojs in the current design. I'll take a look at options for resolving this in a future update of my libraries. |
Thanks for the updates! Please do consider avoiding edits to the source tree during build soon. |
DirectX Tool Kit
ModelMeshPart::InputLayoutCollection
,GeometricPrimitive::VertexCollection
andIndexCollection
.DirectX Tool Kit for DX12
CMO
models added using BasicEffect or SkinnedEffect materialsModel::EffectCollection
,ModelMeshPart::InputLayoutCollection
,GeometricPrimitive::VertexCollection
andIndexCollection
std::initializer_list
DirectXMesh
DirectXTex
UVatlas