-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[simbody] new port #20565
[simbody] new port #20565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for simbody but no changes to version or port version.
-- Version: 3.8-a8f49c84e98ccf3b7e6f05db55a29520e5f9c176
-- Old SHA: 0318add5ca594bd91cf9528c2c4f43568a684bb1
-- New SHA: ce9e89770e2de11117344e4513f0f2042a6f93fe
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/simbody/vcpkg.json b/ports/simbody/vcpkg.json
index 9a1260d..10e559b 100644
--- a/ports/simbody/vcpkg.json
+++ b/ports/simbody/vcpkg.json
@@ -5,8 +5,8 @@
"homepage": "https://simtk.org/home/simbody",
"dependencies": [
"blas",
- "lapack",
"freeglut",
+ "lapack",
{
"name": "vcpkg-cmake",
"host": true
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for simbody but no changes to version or port version.
-- Version: 3.8-a8f49c84e98ccf3b7e6f05db55a29520e5f9c176
-- Old SHA: b975b2b5c1af73928cbb1836195e1254992fff34
-- New SHA: c47ef0b8c82d33259be03a5c5f7b1e21de8ad88b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for simbody but no changes to version or port version.
-- Version: 3.8-a8f49c84e98ccf3b7e6f05db55a29520e5f9c176
-- Old SHA: 6e10fef340118a4f4a0fcf3c29d07634e475fe1a
-- New SHA: de4912412052a2f458cd1786943b144dc56286ce
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for simbody but no changes to version or port version.
-- Version: 3.8-a8f49c84e98ccf3b7e6f05db55a29520e5f9c176
-- Old SHA: be1751762dc6d14fbdc2a8401d509127a69952b6
-- New SHA: 5e2214b873d7ab59b41244554589be9ee8682310
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Thanks for your help to submit the changes to upstream. Let's wait for the upstream changes that will be accepted and merged. |
@NancyLi1013 I have made simbody/simbody#724, but I have received no response from the upstream maintainers for more than 3 weeks. Would it be possible to include the patch files here in an effort to just get this port added? |
Hi @Ace314159, thanks for your PR, we need wait for simbody/simbody#724 merged. |
@LilyWangLL The upstream PR has been merged and I've made the appropriate changes to use it. Is there anything else you'd like me to do? |
Co-authored-by: LilyWangLL <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for simbody but no changes to version or port version.
-- Version: 2022-01-04
-- Old SHA: ffadcf2067f8847dff1557b5247998e915ce9194
-- New SHA: 9474ba4a8027fb4f8e3e160decc4fa9f443a16e9
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
LGTM! Thanks @Ace314159 :) |
This adds the simbody port
What does your PR fix?
Fixes Add simbody #2955 and [New Port Request] Simbody #7705
Which triplets are supported/not supported? Have you updated the CI baseline?
all, Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/