Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asio-grpc] new port #20602

Merged
merged 3 commits into from
Oct 12, 2021
Merged

[asio-grpc] new port #20602

merged 3 commits into from
Oct 12, 2021

Conversation

Tradias
Copy link
Contributor

@Tradias Tradias commented Oct 8, 2021

Describe the pull request

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Oct 8, 2021

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 9, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/asio-grpc/portfile.cmake

ports/asio-grpc/portfile.cmake Outdated Show resolved Hide resolved
ports/asio-grpc/portfile.cmake Outdated Show resolved Hide resolved
ports/asio-grpc/portfile.cmake Outdated Show resolved Hide resolved
ports/asio-grpc/portfile.cmake Outdated Show resolved Hide resolved
ports/asio-grpc/portfile.cmake Outdated Show resolved Hide resolved
ports/asio-grpc/vcpkg.json Outdated Show resolved Hide resolved
ports/asio-grpc/vcpkg.json Outdated Show resolved Hide resolved
@Tradias
Copy link
Contributor Author

Tradias commented Oct 9, 2021

@JonLiu1993 thank you for your suggestions. I have addressed them in the latest commit

@JonLiu1993
Copy link
Member

All feature are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Oct 11, 2021
@BillyONeal BillyONeal merged commit 0ab80cc into microsoft:master Oct 12, 2021
@BillyONeal
Copy link
Member

Thanks for the new port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants