Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libjuice] Update to 0.9.1 #20667

Merged
merged 3 commits into from
Oct 18, 2021
Merged

[libjuice] Update to 0.9.1 #20667

merged 3 commits into from
Oct 18, 2021

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Update to 0.9.1 and update patch to apply the new version.

Update the deprecated functions.

Note: The feature nettle ha passed with the following triplets:

  • x86-windows
  • x64-windows-static

@NancyLi1013 NancyLi1013 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Oct 12, 2021
@Nemirtingas
Copy link
Contributor

Nemirtingas commented Oct 12, 2021 •
edited
Loading

Hi,
I'm pretty sure you need to update:

vcpkg/ports/libdatachannel/portfile.cmake

Line 38 in 0ab80cc

find_dependency(libjuice)

And use LibJuice instead of libjuice. At least, I needed to use LibJuice when I used it on my end.

@NancyLi1013
Copy link
Contributor Author

Thanks for your kindly reminder @Nemirtingas. I also noticed this point and will update it later.

@NancyLi1013
Copy link
Contributor Author

Depends on PR #20737

@NancyLi1013 NancyLi1013 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 15, 2021
@NancyLi1013
Copy link
Contributor Author

/azp run

@NancyLi1013 NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 18, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Oct 18, 2021
@vicroms vicroms merged commit 7e21788 into microsoft:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libjuice] update to 0.9.1
4 participants
@NancyLi1013 @Nemirtingas @JackBoosY @vicroms