-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compoundfilereader] new port #20800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Werni2A
changed the title
Draft: [compoundfilereader] new port
[compoundfilereader] new port
Oct 17, 2021
Werni2A
commented
Oct 17, 2021
JonLiu1993
added
the
category:new-port
The issue is requesting a new library to be added; consider making a PR!
label
Oct 18, 2021
JonLiu1993
requested changes
Oct 18, 2021
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for compoundfilereader but no changes to version or port version.
-- Version: 0.1.0
-- Old SHA: c9cda2c429c5eb38fb47c22b3db721fcf01d73d9
-- New SHA: b91bf9e4b5d94c93ac2ffdfc8785c2ec4d99c9ec
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
JonLiu1993
approved these changes
Oct 18, 2021
Thanks for your help and merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:new-port
The issue is requesting a new library to be added; consider making a PR!
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [New Port Request] compoundfilereader #20783
Which triplets are supported/not supported? Have you updated the CI baseline?
Tested on Linux x64, CI is not updated
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes