Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gRPC] update to v1.41.0 #20835

Merged
merged 28 commits into from
Nov 11, 2021
Merged

[gRPC] update to v1.41.0 #20835

merged 28 commits into from
Nov 11, 2021

Conversation

JonLiu1993
Copy link
Member

@JonLiu1993 JonLiu1993 commented Oct 19, 2021

Fix #19511

Update grpc to the latest version 1.41.0

All feature are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Oct 19, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 078f3e51efd5ea6072d0ba28d11baa946519a2ce -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 6fc0f76..63b0403 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6841,8 +6841,8 @@
       "port-version": 1
     },
     "upb": {
-      "baseline": "2020-12-19",
-      "port-version": 1
+      "baseline": "2021-10-19",
+      "port-version": 0
     },
     "urdfdom": {
       "baseline": "1.0.4",
diff --git a/versions/u-/upb.json b/versions/u-/upb.json
index 6d0406e..b0674e9 100644
--- a/versions/u-/upb.json
+++ b/versions/u-/upb.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "f12e709131ea4cff5b85901468955f7081f39cde",
+      "version-date": "2021-10-19",
+      "port-version": 0
+    },
     {
       "git-tree": "df35bcef11c276d5cc7280edeca76eeff3dad223",
       "version-date": "2020-12-19",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/upb/portfile.cmake

@JonLiu1993 JonLiu1993 marked this pull request as ready for review October 20, 2021 01:54
@JonLiu1993 JonLiu1993 removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Oct 20, 2021
ports/grpc/00006-snprintf.patch Outdated Show resolved Hide resolved
ports/grpc/00010-add-feature-absl-sync.patch Outdated Show resolved Hide resolved
ports/upb/portfile.cmake Outdated Show resolved Hide resolved
ports/upb/portfile.cmake Outdated Show resolved Hide resolved
@JonLiu1993
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Oct 22, 2021
@vicroms vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Oct 22, 2021
@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Oct 27, 2021
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Nov 2, 2021
@BillyONeal
Copy link
Member

@jozefizso @youknowone @coryan Can you take a look at this and comment?

@BillyONeal
Copy link
Member

Related: #17422 (comment)

@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Nov 5, 2021
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 11, 2021
@NancyLi1013
Copy link
Contributor

@BillyONeal Could you please help review this PR again? It should be fine now.

@BillyONeal BillyONeal merged commit 756f184 into microsoft:master Nov 11, 2021
@JonLiu1993 JonLiu1993 deleted the dev/Jon/grpc branch November 12, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gRPC] update to v1.41.0
6 participants