-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bext-sml] Adding new port of boost::sml #20851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think boost-ext-sml
is more clear name for this port.
I was following the example of |
I've just checked DI and UT documentation. Sorry, but I haven't found these examples. I've only found that the |
Those two I brought up are already ports in vcpkg, https://github.com/microsoft/vcpkg/tree/master/ports/bext-di and https://github.com/microsoft/vcpkg/tree/master/ports/bext-ut I don't mind changing it, I just don't know if consistency or a more readable name is better. |
I see. Thank you. But I think searching by name |
I think the name is fine, See #16302 (review) |
bext is a terrible prefix. you could also change the regexp |
I don't understand from the comment why |
This library is not in boost, so it should not use boost- as a prefix. Just because the library wants to claim that it's part of boost, it isn't part of boost until the boost maintainers have accepted it. |
In source code everybody must use #include <boost/di.hpp>
#include <boost/sml.hpp>
#include <boost/ut.hpp> Why in the package name |
For the main registry we are not changing our stance on these two things:
If I recall correctly the An alternative is to create a private repository that uses @misirlou-tg since you're the author of this PR. If you're ok with the current port name let me know so I can merge it. |
@vicroms thanks for clarifying. -On the other hand you could just move it, if the hypothetical library realizes. |
@vicroms Thank you for your detailed answer. |
Yes, I am OK with the name |
Thanks! |
Adding new port of boost::sml
What does your PR fix?
[New Port Request] boost::sml #20799
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/