-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Revise appdeploy and copy_tool_dependencies #21092
Conversation
The original mutex error on linux:
|
... is caused by the |
@BillyONeal Can you please review this PR? |
if ($destModTime -lt $sourceModTime) { | ||
Write-Verbose " ${targetBinaryName}: Updating $SourceDir\$targetBinaryName" | ||
Copy-Item "$SourceDir\$targetBinaryName" $targetBinaryDir | ||
Write-Verbose " ${targetBinaryName}: Updating from $sourceBinaryFilePath" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor output change here.
110% agreed. Additionally, using powershell for this has shown to be no longer sufficient. Both @BillyONeal and I have medium term desires to nuke this in favor of a small portable C++ utility (maybe separate, maybe built-in to vcpkg.exe), however the need for extensibility for plugin producers (Qt, magnum, etc) has made that non-trivial. I hope to eventually find a simple text/json format that can capture all needed information for those cases in a declarative way (and we can add a small amount of hardcoded logic for backwards compatibility to older port versions). |
I just can't put too much in a single PR. |
Thanks! |
[vcpkg] Revise appdeploy and copy_tool_dependencies (microsoft#21092)
What does your PR fix?
catching failingfixing mutex creation.at least when.DEBUG_PORT
is set (cf.debug_message
inports.cmake
)Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?--
For discussion
Logging (-verbose
) might always be enabled. It doesn't clutter output.If there is a better idea how to deal with the mutex creation issue...bin
directory.appdeploy.ps1
twice. It should better take a list of directories as search path instead of a single directory.And it should also take a list of executables (or just a single directory).