Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsercomm] Adding new port #21105

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Conversation

misirlou-tg
Copy link
Contributor

Adds a new port, libsercomm

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/libsercomm/portfile.cmake

@JonLiu1993 JonLiu1993 self-assigned this Nov 1, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 1, 2021
ports/libsercomm/portfile.cmake Outdated Show resolved Hide resolved
- Removing "pic" feature
- Removing PREFER_NINJA from vcpkg_cmake_configure
@JonLiu1993 JonLiu1993 added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed requires:author-response labels Nov 2, 2021
@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-linux

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Nov 2, 2021
@dan-shaw dan-shaw merged commit 85b3115 into microsoft:master Nov 2, 2021
@misirlou-tg misirlou-tg deleted the add-sercomm branch November 2, 2021 19:04
@NangiDev
Copy link

NangiDev commented Nov 3, 2021

Thank you so much!
Great work!

What would be needed to do to get the osX triplet working?
Also other triplets if that's possible.

@GongT
Copy link

GongT commented Mar 9, 2022

I can't use this package.

It install libsercomm/sercommConfig.cmake, but find_package want ether libsercomm/libsercommConfig.cmake or sercomm/sercommConfig.cmake

[cmake] CMake Error at vcpkg/scripts/buildsystems/vcpkg.cmake:800 (_find_package):
[cmake]   Could not find a package configuration file provided by "sercomm" with any
[cmake]   of the following names:
[cmake] 
[cmake]     sercommConfig.cmake
[cmake]     sercomm-config.cmake
[cmake] 
[cmake]   Add the installation prefix of "sercomm" to CMAKE_PREFIX_PATH or set
[cmake]   "sercomm_DIR" to a directory containing one of the above files.  If
[cmake]   "sercomm" provides a separate development package or SDK, be sure it has
[cmake]   been installed.
[cmake] Call Stack (most recent call first):
[cmake]   CMakeLists.txt:49 (find_package)

@JonLiu1993
Copy link
Member

@GongT ,Please post a new issue to describle your question, and we will track your question in your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] libsercomm
6 participants