Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdspan] Add new port for kokkos/mdspan #21170

Merged
merged 7 commits into from
Nov 5, 2021
Merged

Conversation

jdthomas
Copy link
Contributor

@jdthomas jdthomas commented Nov 3, 2021

Adds new port for mdspan

  • What does your PR fix?

    Fixes [New Port Request] mdspan #21183 , adds new port for mdspan

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@ghost
Copy link

ghost commented Nov 3, 2021

CLA assistant check
All CLA requirements met.

@jdthomas jdthomas marked this pull request as ready for review November 3, 2021 20:58
@NancyLi1013 NancyLi1013 self-assigned this Nov 4, 2021
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 4, 2021
ports/mdspan/portfile.cmake Outdated Show resolved Hide resolved
ports/mdspan/portfile.cmake Outdated Show resolved Hide resolved
ports/mdspan/portfile.cmake Outdated Show resolved Hide resolved
ports/mdspan/portfile.cmake Outdated Show resolved Hide resolved
[mdspan] accept all reviewer's suggested changes

Co-authored-by: NancyLi1013 <[email protected]>
ports/mdspan/vcpkg.json Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 5, 2021
@NancyLi1013
Copy link
Contributor

LGTM, thanks for adding this port. @jdthomas

@dan-shaw dan-shaw merged commit f688b48 into microsoft:master Nov 5, 2021
@crtrott
Copy link

crtrott commented Nov 30, 2021

@jdthomas I haven't ever used vcpkg would it be possible to get some guidance on how we can make sure we don't break this integration?

@jdthomas
Copy link
Contributor Author

@jdthomas I haven't ever used vcpkg would it be possible to get some guidance on how we can make sure we don't break this integration?

@crtrott
heh, I am new to this as well, so maybe there's someone better to answer any specific question :)
In the vcpkg repo there's a hard coded sha (aced2cebd362a1e15830da030bd16748131d28bd) that it pulls from the mdspan repo. I think the only maintenance you might be interested in is potentially updating that if mdspan gets updates. Since mdspan takes no external dependencies, I cannot imagine there being any breakage other than potentially while updating (and even then super unlikely unless someone adds another "port" that depends on mdspan). ... but again, i am new to this too 🤷🏽‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] mdspan
5 participants