-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[netcdf-c] Update to 4.8.1, revise features #21239
Conversation
... and here is a strange mix of debug and release 💥 We need to check the imported configurations. |
This configuration comes from
Related: #20289 (comment) |
aws-cpp-sdk is a difficult citizen in vcpkg. It is not ready for vcpkg-style debug+release. It exports dependencies incompletely (missing: s2n, stdc++) and not in the right order for static linkage. |
@dg0yt Can you please report that to https://github.com/aws/aws-sdk-cpp? |
I think we need to make port aws-sdk-cpp etc. up-to-date first. I would suggest to remove feature nczarr-s3 from this port-version of netcdf-c. It needs more work in vcpkg and in upstreams. |
I will restart x64-osx test after the other tests finished. |
You may re-run CI now. x64-linux is blocked for no obvious reason. |
It seems that the feature changes fails to run. |
Strange. The last commit didn't change a bit of port netcdf-c, and the debug run of |
This reverts commit 03f3d52.
All features are tested successfully on x86-windows and x64-windows-static. |
What does your PR fix?
Updates netCDF-C.
Decouples netcdf-4 feature from hdf5. (Hdf5 implies netcdf-4, but not vice versa.)
Fixes hdf5 szip usage with static linkage (assuming it was broken already in previous versions).
Exposes features for the new NCZarr support. (Needs for [aws-sdk-cpp] Fix the path in the export cmake config #21240 for building, but this should not hold back this PR.)
Enables CI build with reduced feature set for uwp and arm64-windows.
Enables using reduced set of dependencies (via explicit feature selection in manifest or with
vcpkg install
).Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes