Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asio-grpc] Update to 1.3.1 #21263

Merged
merged 4 commits into from
Nov 13, 2021
Merged

Conversation

Tradias
Copy link
Contributor

@Tradias Tradias commented Nov 8, 2021

Update asio-grpc to 1.3.1

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, yes

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 721cb5f6e659c7cf823a9e316ed87e73a41f09e4 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/asio-grpc.json b/versions/a-/asio-grpc.json
index 6da80de..950f20a 100644
--- a/versions/a-/asio-grpc.json
+++ b/versions/a-/asio-grpc.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "b67d9084a5b9b4b8f5df833169320cc0c3111b02",
+      "version": "1.3.0",
+      "port-version": 0
+    },
     {
       "git-tree": "39ad0d8203c21698ba153d6951de8295954028eb",
       "version": "1.1.2",
diff --git a/versions/baseline.json b/versions/baseline.json
index 35833c1..98b7f7e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -181,7 +181,7 @@
       "port-version": 0
     },
     "asio-grpc": {
-      "baseline": "1.1.2",
+      "baseline": "1.3.0",
       "port-version": 0
     },
     "asiosdk": {

@JonLiu1993 JonLiu1993 added category:port-update The issue is with a library, which is requesting update new revision category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Nov 9, 2021
ports/asio-grpc/vcpkg.json Outdated Show resolved Hide resolved
@Tradias Tradias changed the title [asio-grpc] Update to 1.3.0 [asio-grpc] Update to 1.3.1 Nov 12, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 721cb5f6e659c7cf823a9e316ed87e73a41f09e4 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/asio-grpc.json b/versions/a-/asio-grpc.json
index da71d2d..92bbd8c 100644
--- a/versions/a-/asio-grpc.json
+++ b/versions/a-/asio-grpc.json
@@ -5,11 +5,6 @@
       "version": "1.3.1",
       "port-version": 0
     },
-    {
-      "git-tree": "b67d9084a5b9b4b8f5df833169320cc0c3111b02",
-      "version": "1.3.0",
-      "port-version": 0
-    },
     {
       "git-tree": "39ad0d8203c21698ba153d6951de8295954028eb",
       "version": "1.1.2",

Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update and awesome library!

@ras0219-msft ras0219-msft merged commit 796d677 into microsoft:master Nov 13, 2021
@Tradias Tradias deleted the update-asio-grpc branch February 25, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants