[ace] Upgrade to ACE 7.0.5, added myself as maintainer #21322

jwillemsen · 2021-11-11T08:17:53Z

Describe the pull request

What does your PR fix?

Upgrade to ACE 7.0.5
Which triplets are supported/not supported? Have you updated the CI baseline?

<same as before>, <Yes>
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

…do's for ACE 7.0.5 when it becomes available * ports/ace/portfile.cmake: * ports/ace/vcpkg.json:

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for ace but no changes to version or port version.
-- Version: 7.0.3#2
-- Old SHA: 67c57059b237310a1907da692fc75acb3d8d2726
-- New SHA: 2287655cbdf417e7f5265da17de6591c03653caf
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

* ports/ace/vcpkg.json:

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/ace/vcpkg.json b/ports/ace/vcpkg.json
index a23ed1d..c77d962 100644
--- a/ports/ace/vcpkg.json
+++ b/ports/ace/vcpkg.json
@@ -1,7 +1,6 @@
 {
   "name": "ace",
   "version": "7.0.4",
-  "port-version": 0,
   "maintainers": "Johnny Willemsen <[email protected]>",
   "description": "The ADAPTIVE Communication Environment",
   "homepage": "https://www.dre.vanderbilt.edu/~schmidt/ACE.html",

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 86b23850c376428633e8690b6983028da0c93683 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/a-/ace.json b/versions/a-/ace.json
index 4e05683..f6e9862 100644
--- a/versions/a-/ace.json
+++ b/versions/a-/ace.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "4989a12c86bc1acabd68489c7b07f55d7cf28537",
+      "version": "7.0.4",
+      "port-version": 0
+    },
     {
       "git-tree": "67c57059b237310a1907da692fc75acb3d8d2726",
       "version": "7.0.3",
diff --git a/versions/baseline.json b/versions/baseline.json
index 1ff8371..b69b4bf 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -17,8 +17,8 @@
       "port-version": 1
     },
     "ace": {
-      "baseline": "7.0.3",
-      "port-version": 2
+      "baseline": "7.0.4",
+      "port-version": 0
     },
     "activemq-cpp": {
       "baseline": "3.9.5",

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 86b23850c376428633e8690b6983028da0c93683 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/a-/ace.json b/versions/a-/ace.json
index e95c5e6..f6e9862 100644
--- a/versions/a-/ace.json
+++ b/versions/a-/ace.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "389ecb011b80c0898b6d5e4aabc58990c51a6cf6",
+      "git-tree": "4989a12c86bc1acabd68489c7b07f55d7cf28537",
       "version": "7.0.4",
       "port-version": 0
     },

JonLiu1993 · 2021-11-12T10:13:38Z

@jwillemsen ,Thanks for your pr, I tested all features in x64-windows triplet locally but failed, Could you please take a look:
build-x64-windows-rel-out.log

jwillemsen · 2021-11-12T10:27:23Z

The error I see is fatal error C1090: PDB API call failed, error code '23' but a google search hints at using the latest Visual Studio 2019 release, which visual studio version are you using?

JonLiu1993 · 2021-11-12T10:29:23Z

The error I see is fatal error C1090: PDB API call failed, error code '23' but a google search hints at using the latest Visual Studio 2019 release, which visual studio version are you using?

Visual Studio 2019

jwillemsen · 2021-11-12T10:31:00Z

But which update, the latest is 16.11.6, see https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes#whats-new-in-visual-studio-2019-version-1611

JonLiu1993 · 2021-11-12T10:37:53Z

But which update, the latest is 16.11.6, see https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes#whats-new-in-visual-studio-2019-version-1611

visual-studio-2019 16.10.4

jwillemsen · 2021-11-12T10:39:00Z

I think you hit a compiler bug, did see more references on the web about this, can you try the latest visual studio release?

JonLiu1993 · 2021-11-12T10:47:03Z

I think you hit a compiler bug, did see more references on the web about this, can you try the latest visual studio release?

Thanks @jwillemsen ,I will update my Visual Studio version and test again.

ports/ace/portfile.cmake

Osyotr · 2021-11-13T09:53:30Z

fatal error C1090: PDB API call failed, error code '23'

Perhaps /Zi is used somewhere.

* ports/ace/portfile.cmake: * ports/ace/vcpkg.json:

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 897ff9372f15c032f1e6cd1b97a59b57d66ee5b2 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/a-/ace.json b/versions/a-/ace.json
index 01d39a5..90827cd 100644
--- a/versions/a-/ace.json
+++ b/versions/a-/ace.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "a9604025e274c6a8522f38f6ddf255aabb2f62d1",
-      "version": "7.0.4",
+      "git-tree": "e58a42a2a7c97e1de8912324cdfba7d60aac8dac",
+      "version": "7.0.5",
       "port-version": 0
     },
     {
diff --git a/versions/baseline.json b/versions/baseline.json
index f222011..9aa911e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -17,7 +17,7 @@
       "port-version": 1
     },
     "ace": {
-      "baseline": "7.0.4",
+      "baseline": "7.0.5",
       "port-version": 0
     },
     "activemq-cpp": {

ports/ace/portfile.cmake

* ports/ace/portfile.cmake:

… jwi-ace704

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 897ff9372f15c032f1e6cd1b97a59b57d66ee5b2 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/a-/ace.json b/versions/a-/ace.json
index 90827cd..465a32b 100644
--- a/versions/a-/ace.json
+++ b/versions/a-/ace.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "e58a42a2a7c97e1de8912324cdfba7d60aac8dac",
+      "git-tree": "bcc74bda3a7d8c6a93ff6ff5866de20612661fc3",
       "version": "7.0.5",
       "port-version": 0
     },

JonLiu1993 · 2021-11-18T02:05:25Z

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

JonLiu1993 · 2021-11-18T02:06:28Z

Thanks everyone for your contribution

vicroms · 2021-11-19T04:56:23Z

Thanks for the PR!

[ace] Upgrade to ACE 7.0.4, added myself as maintainer, added some to…

ce42b5d

…do's for ACE 7.0.5 when it becomes available * ports/ace/portfile.cmake: * ports/ace/vcpkg.json:

jwillemsen changed the title ~~[ace] Upgrade to ACE 7.0.4, added myself as maintainer, added some to~~ [ace] Upgrade to ACE 7.0.4, added myself as maintainer, added some todo Nov 11, 2021

github-actions bot requested changes Nov 11, 2021

View reviewed changes

[ace] Update port file

f10b22c

* ports/ace/vcpkg.json:

github-actions bot requested changes Nov 11, 2021

View reviewed changes

[ace] Upgrade to 7.0.4

0209a09

github-actions bot requested changes Nov 11, 2021

View reviewed changes

[ace] Updated version database

59cac6e

github-actions bot approved these changes Nov 11, 2021

View reviewed changes

JonLiu1993 self-assigned this Nov 11, 2021

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 11, 2021

JonLiu1993 removed their assignment Nov 12, 2021

JonLiu1993 added 2 commits November 12, 2021 15:22

fix confict files

5a6ecb2

update version

e8e464c

github-actions bot approved these changes Nov 12, 2021

View reviewed changes

JonLiu1993 approved these changes Nov 12, 2021

View reviewed changes

JonLiu1993 added the requires:author-response label Nov 12, 2021

JonLiu1993 added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed requires:author-response labels Nov 12, 2021

jwillemsen mentioned this pull request Nov 12, 2021

[ace] new optional feature: xml-utils #21334

Merged

mitza-oci reviewed Nov 12, 2021

View reviewed changes

ports/ace/portfile.cmake Outdated Show resolved Hide resolved

[ace] Upgrade to 7.0.5

de5c4cd

* ports/ace/portfile.cmake: * ports/ace/vcpkg.json:

jwillemsen changed the title ~~[ace] Upgrade to ACE 7.0.4, added myself as maintainer, added some todo~~ [ace] Upgrade to ACE 7.0.5, added myself as maintainer Nov 17, 2021

github-actions bot requested changes Nov 17, 2021

View reviewed changes

[ace] Updated version database

2309c82

github-actions bot approved these changes Nov 17, 2021

View reviewed changes

jwillemsen requested a review from JonLiu1993 November 17, 2021 10:55

mitza-oci reviewed Nov 17, 2021

View reviewed changes

ports/ace/portfile.cmake Outdated Show resolved Hide resolved

jwillemsen added 2 commits November 17, 2021 17:11

[ace] Make platform toolset more maintainable

4bf4a8d

* ports/ace/portfile.cmake:

Merge branch 'jwi-ace704' of https://github.com/jwillemsen/vcpkg into…

d7bfe77

… jwi-ace704

github-actions bot requested changes Nov 17, 2021

View reviewed changes

Updated version database

0bf4a1e

github-actions bot approved these changes Nov 17, 2021

View reviewed changes

JonLiu1993 removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Nov 18, 2021

JonLiu1993 approved these changes Nov 18, 2021

View reviewed changes

JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Nov 18, 2021

vicroms merged commit 3fe9e06 into microsoft:master Nov 19, 2021

jwillemsen deleted the jwi-ace704 branch November 19, 2021 06:57

JonLiu1993 mentioned this pull request Dec 15, 2021

[ace:x86-windows] build failure #16551

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ace] Upgrade to ACE 7.0.5, added myself as maintainer #21322

[ace] Upgrade to ACE 7.0.5, added myself as maintainer #21322

jwillemsen commented Nov 11, 2021 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

JonLiu1993 commented Nov 12, 2021

jwillemsen commented Nov 12, 2021

JonLiu1993 commented Nov 12, 2021

jwillemsen commented Nov 12, 2021

JonLiu1993 commented Nov 12, 2021

jwillemsen commented Nov 12, 2021

JonLiu1993 commented Nov 12, 2021

Osyotr commented Nov 13, 2021

github-actions bot left a comment

github-actions bot left a comment

JonLiu1993 commented Nov 18, 2021

JonLiu1993 commented Nov 18, 2021

vicroms commented Nov 19, 2021

[ace] Upgrade to ACE 7.0.5, added myself as maintainer #21322

[ace] Upgrade to ACE 7.0.5, added myself as maintainer #21322

Conversation

jwillemsen commented Nov 11, 2021 • edited Loading

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Nov 12, 2021

jwillemsen commented Nov 12, 2021

JonLiu1993 commented Nov 12, 2021

jwillemsen commented Nov 12, 2021

JonLiu1993 commented Nov 12, 2021

jwillemsen commented Nov 12, 2021

JonLiu1993 commented Nov 12, 2021

Osyotr commented Nov 13, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Nov 18, 2021

JonLiu1993 commented Nov 18, 2021

vicroms commented Nov 19, 2021

jwillemsen commented Nov 11, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?