-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libmariadb] Update #21359
[libmariadb] Update #21359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 8cfe802099de05ed9abab9a63db2524dd1fe1cae -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libmariadb.json b/versions/l-/libmariadb.json
index de3e23b..ef74de4 100644
--- a/versions/l-/libmariadb.json
+++ b/versions/l-/libmariadb.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "e9eb8998b029cbf5366d83123f336684087ddda9",
+ "git-tree": "d591e2208faeb3b72cbfc1542dfe5b7730eeda25",
"version-semver": "3.1.15",
"port-version": 0
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 8cfe802099de05ed9abab9a63db2524dd1fe1cae -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libmariadb.json b/versions/l-/libmariadb.json
index de3e23b..6401cd7 100644
--- a/versions/l-/libmariadb.json
+++ b/versions/l-/libmariadb.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "e9eb8998b029cbf5366d83123f336684087ddda9",
+ "git-tree": "59d761c2579c8bffccfc6f2017f57821763dd383",
"version-semver": "3.1.15",
"port-version": 0
},
b31426d
to
7e026ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for gdal but no changes to version or port version.
-- Version: 3.3.2#4
-- Old SHA: a9ec2540fda2dfe657e004b70d5ca5a1cc7a2db8
-- New SHA: 3fcdbf9adb5b04dd6635b24bcaa398685127c760
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for poco but no changes to version or port version.
-- Version: 1.11.0
-- Old SHA: e8f4d5c1548d23526e05b069ee626d7d7f9a4399
-- New SHA: e5baee9bb5b06a8e33ad43c073194be9d41c8a97
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 8cfe802099de05ed9abab9a63db2524dd1fe1cae -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libmariadb.json b/versions/l-/libmariadb.json
index 4c7dde0..b715d6c 100644
--- a/versions/l-/libmariadb.json
+++ b/versions/l-/libmariadb.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "a2e5c4471ef31b3ced389aff253adc7ac9fce470",
+ "git-tree": "9827e88fd6f6f00b3ac2e0a33c76b0dad8a5f5c6",
"version-semver": "3.1.15",
"port-version": 0
},
https://dev.azure.com/vcpkg/public/_build/results?buildId=62947&view=results validated the build and the exported configuration:
|
I removed the CI baseline skip for |
The |
It may be better for users to provide optional features |
In addition, mariadb also suffers from an unguarded |
All features are tested successfully in the following triplet:
|
What does your PR fix?
Updates libmariadb to 3.1.15.
Modernizes the portfile.
Always uses zlib from vcpkg (resolves [libmariadb] build failure with feature zlib disabled #20369).
Retains
plugins
.Fixes cmake config and pc file.
Adds proper namespace
unofficial
to exported targets.Exports a valid pc file also for Windows.
Drops the
mariadb_config
executable (not for windows, and not relocatable).Adds schannel as SSL backend for Windows (default).
DisablesAdds an optional feature for the extramariadbclient
lib which is always static, but otherwise not different fromlibmariadb
AFAICT.Enables CI for
x86-windows
.Which triplets are supported/not supported? Have you updated the CI baseline?
all but UWP, yes.
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes