Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zlib-ng] Update to 2.0.5 #21366

Merged
merged 2 commits into from
Nov 16, 2021
Merged

[zlib-ng] Update to 2.0.5 #21366

merged 2 commits into from
Nov 16, 2021

Conversation

chausner
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    This updates zlib-ng to 2.0.5.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    As before, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@luncliff
Copy link
Contributor

luncliff commented Nov 14, 2021

The port has a bug for arm64-osx, arm64-ios now. Would you consider adding WITH_NATIVE_INSTRUCTIONS=OFF change in this PR?

https://github.com/luncliff/vcpkg-registry/blob/main/ports/zlib-ng/portfile.cmake#L16


My bad, its default value was OFF. Never mind. 😕

@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Nov 15, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Nov 15, 2021
@dan-shaw dan-shaw merged commit 9722212 into microsoft:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants