Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qtkeychain] update to 0.13.1 #21420

Merged
merged 1 commit into from
Nov 15, 2021
Merged

[qtkeychain] update to 0.13.1 #21420

merged 1 commit into from
Nov 15, 2021

Conversation

ras0219-msft
Copy link
Contributor

@ras0219-msft ras0219-msft commented Nov 14, 2021 •
edited
Loading

Cherry-picked from #20185 with:

  1. Warning and adjusted description to better inform users that qtkeychain is not affiliated with The Qt Company
  2. Revert to original port names -- while it would be nice to have qtkeychain's naming match with qttools vs qt5-tools, that is absolutely not worth breaking customers on upgrade that currently expect qtkeychain to come with qt5.

@Be-ing @ras0219-msft
[qtkeychain] update to 0.13.1
f582948 
and add libsecret as a dependency for Linux
@ras0219-msft ras0219-msft mentioned this pull request Nov 14, 2021
Closed
@Be-ing
Copy link
Contributor

Be-ing commented Nov 15, 2021

It does not matter to me whether this or #20185 is merged; either works.

@JackBoosY JackBoosY added category:port-update The issue is with a library, which is requesting update new revision category:new-port The issue is requesting a new library to be added; consider making a PR! info:internal This PR or Issue was filed by the vcpkg team. labels Nov 15, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 15, 2021
@JackBoosY
Copy link
Contributor

Already checked the generated files.

@ras0219-msft ras0219-msft merged commit 4803020 into microsoft:master Nov 15, 2021
@ras0219-msft
Copy link
Contributor Author

Thanks @Be-ing and sorry that it took so long to get #20185 addressed!

@ras0219-msft ras0219-msft deleted the dev/roschuma/qtkeychain branch November 15, 2021 16:54
@Be-ing
Copy link
Contributor

Be-ing commented Nov 15, 2021

Thanks for finishing this.

@Be-ing Be-ing mentioned this pull request Nov 16, 2021
Closed
Be-ing added a commit to Be-ing/vcpkg that referenced this pull request Nov 20, 2021
@Be-ing
[qtkeychain] remove from overlay
e1f6539 
microsoft#21420 was merged upstream
updating qtkeychain and adding Qt6 compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ras0219-msft @Be-ing @JackBoosY