Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libarchive] Fix usage #21426

Merged
merged 2 commits into from
Nov 17, 2021
Merged

[libarchive] Fix usage #21426

merged 2 commits into from
Nov 17, 2021

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Nov 15, 2021 •
edited
Loading

Fix usage, cmake provides FindLibArchive.cmake, so the PACKAGE_NAME should be LibArchive.

Fixes #21408.

Already tested the usage.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 15, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 16, 2021
@vicroms vicroms merged commit ba64748 into microsoft:master Nov 17, 2021
@JackBoosY JackBoosY deleted the dev/jack/21408 branch November 17, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libarchive] fix suggested name after install
4 participants
@JackBoosY @dg0yt @NancyLi1013 @vicroms