extend platform expressions to support media query syntax - terminals… #21444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'and', 'not' and ',' for logical-and, -not and -or operators
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
added
category:documentation
|
I'm not sure that, needs other guys to review this. |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to support media queries syntax in platform expressions.
In media queries syntax (Media Queries):
This change extends platform expressions by using the same list-separator model for "," and by adding the other terminals ("and", "not") as synonyms for the corresponding operators that are already supported ("&", "!"). This change also adds "or" as a synonym for "|" as a potential future extension.
Open question: does the EBNF need to disambiguate "and", "not", "or" as keywords and not identifiers?