-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus-cpp] Update to version 1.0.0 #21500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/prometheus-cpp/portfile.cmake
27e2b76
to
f7678b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f33d743a757fc50da77a2bd3a4cf5d55c4f5e02f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/p-/prometheus-cpp.json b/versions/p-/prometheus-cpp.json
index c487f20..b098e58 100644
--- a/versions/p-/prometheus-cpp.json
+++ b/versions/p-/prometheus-cpp.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "006340fb5e50a4215b7de707e64e4248296de6bc",
+ "git-tree": "e7cad89eebc18bb1ce887313558809b702e50441",
"version-semver": "1.0.0",
"port-version": 0
},
f7678b5
to
d820689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f33d743a757fc50da77a2bd3a4cf5d55c4f5e02f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/p-/prometheus-cpp.json b/versions/p-/prometheus-cpp.json
index c487f20..7518f04 100644
--- a/versions/p-/prometheus-cpp.json
+++ b/versions/p-/prometheus-cpp.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "006340fb5e50a4215b7de707e64e4248296de6bc",
+ "git-tree": "4cffac1d2fb4d99d57d042d93c6913453f68f9b8",
"version-semver": "1.0.0",
"port-version": 0
},
d820689
to
87b872d
Compare
@gjasny ,Have you tested the features locally? |
87b872d
to
e22b1f8
Compare
Yes, locally on my mac. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout cbc22a396c88d098247fe7f79f0913a952e1f77d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/p-/prometheus-cpp.json b/versions/p-/prometheus-cpp.json
index 7518f04..9ca74e8 100644
--- a/versions/p-/prometheus-cpp.json
+++ b/versions/p-/prometheus-cpp.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "4cffac1d2fb4d99d57d042d93c6913453f68f9b8",
+ "git-tree": "8f679ed963f525e155342a6be082d02e03c96856",
"version-semver": "1.0.0",
"port-version": 0
},
e22b1f8
to
b139d2f
Compare
All features are tested successfully in the following triplet:
|
Update prometheus-cpp to 1.0.0. Locally tested all the features on macOS.