Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes] Update to the latest version #21503

Merged
merged 7 commits into from
Nov 19, 2021

Conversation

ahmedyarub
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Update Kubernetes client library to the latest version, mainly to fix static/dynamic libwebsockets linking

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout cbc22a396c88d098247fe7f79f0913a952e1f77d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/k-/kubernetes.json b/versions/k-/kubernetes.json
index 3db4fc6..86a5923 100644
--- a/versions/k-/kubernetes.json
+++ b/versions/k-/kubernetes.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "1764dd7b5dbdd457e3c14a97fa7bdfdaa7e50713",
+      "git-tree": "e5bf0e8b0108dbe4d5a4821487770e048be13bfd",
       "version": "0.0.1",
       "port-version": 1
     },

@JonLiu1993 JonLiu1993 self-assigned this Nov 18, 2021
@JonLiu1993 JonLiu1993 changed the title Ay/kubernetes client [kubernetes] Update to the latest version Nov 18, 2021
ports/kubernetes/vcpkg.json Outdated Show resolved Hide resolved
@JonLiu1993
Copy link
Member

@ahmedyarub ,Thanks for your pr, please run the command "./vcpkg x-add-version --overwrite-version" after modify the pr

@JonLiu1993 JonLiu1993 added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Nov 18, 2021
ports/kubernetes/vcpkg.json Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kubernetes but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: d52624c3f3a26d3ad801cca6af68e7bd8273b29b
-- New SHA: 83cc58709e3b72ebb24afac2bf1884a249f1da44
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout cbc22a396c88d098247fe7f79f0913a952e1f77d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/k-/kubernetes.json b/versions/k-/kubernetes.json
index 9222321..8ef4fa3 100644
--- a/versions/k-/kubernetes.json
+++ b/versions/k-/kubernetes.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "83cc58709e3b72ebb24afac2bf1884a249f1da44",
+      "git-tree": "d52624c3f3a26d3ad801cca6af68e7bd8273b29b",
       "version": "0.0.1",
       "port-version": 0
     }

@JonLiu1993
Copy link
Member

Please run the command "./vcpkg x-add-version kubernetes --overwrite-version" and commit again

@ahmedyarub
Copy link
Contributor Author

Please run the command "./vcpkg x-add-version kubernetes --overwrite-version" and commit again

Did that but there is nothing to commit.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout cbc22a396c88d098247fe7f79f0913a952e1f77d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/k-/kubernetes.json b/versions/k-/kubernetes.json
index eca691d..ef7522f 100644
--- a/versions/k-/kubernetes.json
+++ b/versions/k-/kubernetes.json
@@ -6,7 +6,7 @@
       "port-version": 0
     },
     {
-      "git-tree": "83cc58709e3b72ebb24afac2bf1884a249f1da44",
+      "git-tree": "d52624c3f3a26d3ad801cca6af68e7bd8273b29b",
       "version": "0.0.1",
       "port-version": 0
     }

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Nov 19, 2021
@vicroms vicroms merged commit 9688695 into microsoft:master Nov 19, 2021
@ahmedyarub ahmedyarub deleted the ay/kubernetes_client branch November 22, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants