Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buck-yeh-bux-mariadb-client] New port #21505

Merged
merged 58 commits into from
Nov 22, 2021
Merged

Conversation

buck-yeh
Copy link
Contributor

@buck-yeh buck-yeh commented Nov 18, 2021

Loose-coupled Throw-On-Error C++20 wrapper classes and utilities of mysql/mariadb Connector/C API

  • What does your PR fix?

    Nothing.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Supported

    • x64-windows
    • x64-windows-static
    • x64-windows-static-md
    • x86-windows
    • x86-windows-static
    • x86-windows-static-md

    Yes! x64-linux is marked fail because in the real world any up-to-date linux C++ compiler will build but not in CI build here.

    buck-yeh-bux:x64-linux=fail
    buck-yeh-bux-mariadb-client:x64-linux=fail
    
  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

buck-yeh and others added 30 commits August 18, 2021 03:35
@buck-yeh
Copy link
Contributor Author

Where can I get this log /mnt/vcpkg-ci/buildtrees/buck-yeh-bux/install-x64-linux-dbg-out.log from details of x86-linux check?

@JonLiu1993
Copy link
Member

Where can I get this log /mnt/vcpkg-ci/buildtrees/buck-yeh-bux/install-x64-linux-dbg-out.log from details of x86-linux check?

Here is the details log:
install-x64-linux-dbg-out.log

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout cbc22a396c88d098247fe7f79f0913a952e1f77d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/buck-yeh-bux.json b/versions/b-/buck-yeh-bux.json
index c5766c9e..cde398a0 100644
--- a/versions/b-/buck-yeh-bux.json
+++ b/versions/b-/buck-yeh-bux.json
@@ -5,6 +5,11 @@
       "version": "1.6.3",
       "port-version": 0
     },
+    {
+      "git-tree": "c952bbb93f152d6db8e4bc8d0fbed4fb6e7ead2a",
+      "version": "1.6.2",
+      "port-version": 0
+    },
     {
       "git-tree": "fa8f4e2afd3a69f94ed947a1dfc0dcb4006ae9c9",
       "version": "1.6.0",

@buck-yeh
Copy link
Contributor Author

Need /mnt/vcpkg-ci/buildtrees/buck-yeh-bux/install-x64-linux-dbg-out.log to see what is going on in x64-linux build again.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 21, 2021

Need /mnt/vcpkg-ci/buildtrees/buck-yeh-bux/install-x64-linux-dbg-out.log to see what is going on in x64-linux build again.

Follow the details links from GH to Azure Pipelines, then follow the links to your PR's CI runs artifacts, then go to the line with the failure log for x64-linux, then click the three dots on the right side and choose download.

@buck-yeh buck-yeh closed this Nov 21, 2021
@buck-yeh
Copy link
Contributor Author

I got all log files following your directions. Thank you!

In install-x64-linux-dbg-out.log I read:

[1/20] /usr/bin/c++  -I/mnt/vcpkg-ci/buildtrees/buck-yeh-bux/src/c9e66a4664-c1c802f90b.clean/src/../include/bux -fPIC -Wall -Wextra -Wshadow -Wconversion -Wno-parentheses -Wno-unknown-pragmas -g3 -Og -std=c++2a -g -MD -MT src/CMakeFiles/bux.dir/FileLog.cpp.o -MF src/CMakeFiles/bux.dir/FileLog.cpp.o.d -o src/CMakeFiles/bux.dir/FileLog.cpp.o -c /mnt/vcpkg-ci/buildtrees/buck-yeh-bux/src/c9e66a4664-c1c802f90b.clean/src/FileLog.cpp
FAILED: src/CMakeFiles/bux.dir/FileLog.cpp.o 
/usr/bin/c++  -I/mnt/vcpkg-ci/buildtrees/buck-yeh-bux/src/c9e66a4664-c1c802f90b.clean/src/../include/bux -fPIC -Wall -Wextra -Wshadow -Wconversion -Wno-parentheses -Wno-unknown-pragmas -g3 -Og -std=c++2a -g -MD -MT src/CMakeFiles/bux.dir/FileLog.cpp.o -MF src/CMakeFiles/bux.dir/FileLog.cpp.o.d -o src/CMakeFiles/bux.dir/FileLog.cpp.o -c /mnt/vcpkg-ci/buildtrees/buck-yeh-bux/src/c9e66a4664-c1c802f90b.clean/src/FileLog.cpp
In file included from /mnt/vcpkg-ci/buildtrees/buck-yeh-bux/src/c9e66a4664-c1c802f90b.clean/src/../include/bux/FileLog.h:3,
                 from /mnt/vcpkg-ci/buildtrees/buck-yeh-bux/src/c9e66a4664-c1c802f90b.clean/src/FileLog.cpp:1:
/mnt/vcpkg-ci/buildtrees/buck-yeh-bux/src/c9e66a4664-c1c802f90b.clean/src/../include/bux/SyncLog.h:4:10: fatal error: concepts: No such file or directory
    4 | #include <concepts>     // std::convertible_to<>, std::derived_from<>
      |          ^~~~~~~~~~
compilation terminated.

The C++ compiler accepts -std=c++2a but not -std=c++20, and does not recognize header <concepts> yet. This leaves me no choice but change back vcpkg.json's "supports" setting to:

"supports": "!(arm | uwp | osx | linux)",

at least fort now.

@buck-yeh buck-yeh reopened this Nov 21, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout cbc22a396c88d098247fe7f79f0913a952e1f77d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/buck-yeh-bux.json b/versions/b-/buck-yeh-bux.json
index 32b98521..17a797dd 100644
--- a/versions/b-/buck-yeh-bux.json
+++ b/versions/b-/buck-yeh-bux.json
@@ -5,6 +5,11 @@
       "version": "1.6.3",
       "port-version": 0
     },
+    {
+      "git-tree": "c952bbb93f152d6db8e4bc8d0fbed4fb6e7ead2a",
+      "version": "1.6.2",
+      "port-version": 0
+    },
     {
       "git-tree": "fa8f4e2afd3a69f94ed947a1dfc0dcb4006ae9c9",
       "version": "1.6.0",

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout cbc22a396c88d098247fe7f79f0913a952e1f77d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/buck-yeh-bux.json b/versions/b-/buck-yeh-bux.json
index 32b98521..17a797dd 100644
--- a/versions/b-/buck-yeh-bux.json
+++ b/versions/b-/buck-yeh-bux.json
@@ -5,6 +5,11 @@
       "version": "1.6.3",
       "port-version": 0
     },
+    {
+      "git-tree": "c952bbb93f152d6db8e4bc8d0fbed4fb6e7ead2a",
+      "version": "1.6.2",
+      "port-version": 0
+    },
     {
       "git-tree": "fa8f4e2afd3a69f94ed947a1dfc0dcb4006ae9c9",
       "version": "1.6.0",

@dg0yt
Copy link
Contributor

dg0yt commented Nov 21, 2021

The C++ compiler accepts -std=c++2a but not -std=c++20, and does not recognize header <concepts> yet. This leaves me no choice but change back vcpkg.json's "supports" setting to:

"supports": "!(arm | uwp | osx | linux)",

at least fort now.

No, linux seems to be supported with a modern compiler. vcpkg linux CI isn't modern. So the solution is to add this to the ci baseline list of failures.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout cbc22a396c88d098247fe7f79f0913a952e1f77d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/buck-yeh-bux.json b/versions/b-/buck-yeh-bux.json
index c5766c9e..cde398a0 100644
--- a/versions/b-/buck-yeh-bux.json
+++ b/versions/b-/buck-yeh-bux.json
@@ -5,6 +5,11 @@
       "version": "1.6.3",
       "port-version": 0
     },
+    {
+      "git-tree": "c952bbb93f152d6db8e4bc8d0fbed4fb6e7ead2a",
+      "version": "1.6.2",
+      "port-version": 0
+    },
     {
       "git-tree": "fa8f4e2afd3a69f94ed947a1dfc0dcb4006ae9c9",
       "version": "1.6.0",

@buck-yeh
Copy link
Contributor Author

buck-yeh commented Nov 22, 2021

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout cbc22a396c88d098247fe7f79f0913a952e1f77d -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/b-/buck-yeh-bux.json b/versions/b-/buck-yeh-bux.json
index c5766c9e..cde398a0 100644
--- a/versions/b-/buck-yeh-bux.json
+++ b/versions/b-/buck-yeh-bux.json
@@ -5,6 +5,11 @@
       "version": "1.6.3",
       "port-version": 0
     },
+    {
+      "git-tree": "c952bbb93f152d6db8e4bc8d0fbed4fb6e7ead2a",
+      "version": "1.6.2",
+      "port-version": 0
+    },
     {
       "git-tree": "fa8f4e2afd3a69f94ed947a1dfc0dcb4006ae9c9",
       "version": "1.6.0",

buck-yeh-bux 1.6.2 uses -std=c++20 & is not accepted by CI's x64-linux build. Hence it is skipped.

@buck-yeh buck-yeh closed this Nov 22, 2021
@buck-yeh buck-yeh reopened this Nov 22, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout cbc22a396c88d098247fe7f79f0913a952e1f77d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/b-/buck-yeh-bux.json b/versions/b-/buck-yeh-bux.json
index c5766c9e..cde398a0 100644
--- a/versions/b-/buck-yeh-bux.json
+++ b/versions/b-/buck-yeh-bux.json
@@ -5,6 +5,11 @@
       "version": "1.6.3",
       "port-version": 0
     },
+    {
+      "git-tree": "c952bbb93f152d6db8e4bc8d0fbed4fb6e7ead2a",
+      "version": "1.6.2",
+      "port-version": 0
+    },
     {
       "git-tree": "fa8f4e2afd3a69f94ed947a1dfc0dcb4006ae9c9",
       "version": "1.6.0",

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 22, 2021
@JonLiu1993
Copy link
Member

Thanks for your hard working

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after build completes.

@BillyONeal BillyONeal merged commit 600e034 into microsoft:master Nov 22, 2021
@BillyONeal
Copy link
Member

Thanks for the new port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants