-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qt5-base] no absolute paths #21568
[qt5-base] no absolute paths #21568
Conversation
@Neumann-A Are you OK with this? |
yeah but I don't guarantee that the pc files will be useable with that. Especially for static builds the pc files might be wrong or missing stuff. |
also there are probably still absolute paths to the winsdk in the qt files. |
Do you think it's worth a shot anyway?
Probably :( |
You can try but I there is currently nothing testing qt pc files. qmake uses the prl stuff and cmake uses the cmake configs. Only meson/autotools would possibly use pc files for qt. |
I assume the #14225 issue still stands, so they will remain unusable anyway. |
unless you use a single configuration triplet on osx? |
Well, the only Qt .pc files being installed are those with EDIT: also, is this specific to macOS only? |
filelist for osx disagrees lib/pkgconfig has qt stuff.
windows: no pkgconfig files qt6 doesn't seem to install pkgconfig files at all |
That's what I have here:
|
Ah, my bad, had my find limited to |
8b302df
to
f622a56
Compare
I did this mainly so that microsoft/vcpkg-tool#172 can be merged. Imho this PR is a small improvement over the status quo. My intention was not to fix all pkgconfig issues of Qt |
Yes, that's fair. We stole your thunder here a bit, our discussion belongs to #14225, sorry for that! |
@Neumann-A @wrobelda I was mainly making sure that this wouldn't cause things to break horribly, not necessarily to make sure all pkgconfig ills of qt are fixed. :P From the feedback above this seems safe to merge. |
@autoantwort Thanks for the fix! |
For #20469