[v8] msys git succeeds but returns error code 255 which is neglible as far as I can tell. #21620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Yeah, we already found the google repos are unstable, maybe they will fix them in one week. |
JackBoosY
added
the
category:port-bug
|
I was forced to engage Twitter Driven Development https://twitter.com/sokac/status/1463182302679220230 |
|
I think upstream has fixed it and as a result this PR should be closed. Do you agree? |
|
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes v8. The git tool returns a 255 when trying to checkout the googletest repo which itself has an issue with finding the default branch to checkout. Adding the --no-checkout seems to resolve any error associated with finding the default branch but git still returns 255. After looking through the code, it seems the 255 is not really relevant to any error and only seems to happen on the msys git version.
What does your PR fix?
Fixes #...
Which triplets are supported/not supported? Have you updated the CI baseline?
<all / linux, windows, ...>, <Yes/No>
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/