Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glib] update to 2.70.1 #21676

Merged
merged 8 commits into from
Nov 29, 2021
Merged

Conversation

Neumann-A
Copy link
Contributor

No description provided.

@Neumann-A
Copy link
Contributor Author

@BillyONeal what happend to x64-osx? Never saw that error.

Attempting to fetch 134 packages from HTTP servers.
Exception: /Users/vagrant/Data/work/1/s/scripts/azure-pipelines/test-modified-ports.ps1:199
Line |
 199 |          throw "vcpkg ci failed"
     |          ~~~~~~~~~~~~~~~~~~~~~~~
     | vcpkg ci failed

##[error]PowerShell exited with code '1'.
##[error]PowerShell wrote one or more lines to the standard error stream.
##[error]Exception: /Users/vagrant/Data/work/1/s/scripts/azure-pipelines/test-modified-ports.ps1:199
Line |
 199 |          throw "vcpkg ci failed"
     |          ~~~~~~~~~~~~~~~~~~~~~~~
     | vcpkg ci failed

@dg0yt
Copy link
Contributor

dg0yt commented Nov 26, 2021

This osx error already appeared randomly in the last weeks.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b3cfaaf1bba70febd07c2f672ae590dc5d914180 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/g-/glib.json b/versions/g-/glib.json
index 5ee0856..6efc32a 100644
--- a/versions/g-/glib.json
+++ b/versions/g-/glib.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "3e19067c192daf332322962db0c507b1a10ac4bf",
+      "git-tree": "21a2facd76ae194ca1880c497122f7785750f912",
       "version": "2.70.1",
       "port-version": 0
     },

@JonLiu1993 JonLiu1993 self-assigned this Nov 29, 2021
@JonLiu1993 JonLiu1993 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Nov 29, 2021
@JonLiu1993 JonLiu1993 linked an issue Nov 29, 2021 that may be closed by this pull request
@JonLiu1993
Copy link
Member

@Neumann-A ,Thanks for your pr, I tested features locally on x64-linux triplet but failed :

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: /usr/bin/python3 /home/test1/vcpkg/downloads/tools/meson/meson-aeda7f249c4a5dbbecc52e44f382246a2377b5b0/meson.py -Dinstalled_tests=false -Dselinux=enabled -Dlibmount=enabled -Dtests=false -Dxattr=false -Dlibelf=disabled --buildtype plain --backend ninja --wrap-mode nodownload --native /home/test1/vcpkg/buildtrees/glib/meson-native-x64-linux.log --default-library static --libdir lib --native /home/test1/vcpkg/buildtrees/glib/meson-native-x64-linux-debug.log -Ddebug=true --prefix /home/test1/vcpkg/packages/glib_x64-linux/debug --includedir ../include -Dcmake_prefix_path=['/home/test1/vcpkg/installed/x64-linux/debug','/home/test1/vcpkg/installed/x64-linux'] /home/test1/vcpkg/buildtrees/glib/src/glib-2-3e22263b95.clean
    Working Directory: /home/vzhli17/test1/vcpkg/buildtrees/glib/x64-linux-dbg
    Error code: 1
    See logs for more information:
      /home/test1/vcpkg/buildtrees/glib/config-x64-linux-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_meson.cmake:512 (vcpkg_execute_required_process)
  ports/glib/portfile.cmake:46 (vcpkg_configure_meson)
  scripts/ports.cmake:142 (include)

/home/test1/vcpkg/buildtrees/glib/x64-linux-dbg:

../src/glib-2-3e22263b95.clean/meson.build:2077:2: ERROR: Dependency "libselinux" not found, tried pkgconfig and cmake

A full log can be found at /home/test1/vcpkg/buildtrees/glib/x64-linux-dbg/meson-logs/meson-log.txt

/home/test1/vcpkg/buildtrees/glib/x64-linux-dbg/meson-logs/meson-log.txt:

Compiler stderr:
 /home/test1/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmprk8e3u5r/testfile.c:4:12: error: #error "Header 'mach/mach_time.h' could not be found"
           #error "Header 'mach/mach_time.h' could not be found"
            ^~~~~

Has header "mach/mach_time.h" : NO
Running compile:
Working directory:  /home/test1/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmppavpsk6g
Command line:  /usr/bin/cc -I/home/test1/vcpkg/installed/x64-linux/include /home/test1/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmppavpsk6g/testfile.c -E -P -fPIC -g -D_FILE_OFFSET_BITS=64 -P -O0 -std=gnu99

@Neumann-A
Copy link
Contributor Author

@JonLiu1993: I assume you are missing a system dependency if you want to enable feature selinux (ERROR: Dependency "libselinux" not found, tried pkgconfig)

mach/mach_time.h is a osx header according to a quick google search so it is no wonder that it is missing on linux.

@JonLiu1993
Copy link
Member

@JonLiu1993: I assume you are missing a system dependency if you want to enable feature selinux (ERROR: Dependency "libselinux" not found, tried pkgconfig)

mach/mach_time.h is a osx header according to a quick google search so it is no wonder that it is missing on linux.

Have you tested all features locally?

@Neumann-A
Copy link
Contributor Author

Have you tested all features locally?

Have you tested the current baseline with the same features?
No I cannot test everything locally, especially not osx.
I can tell you that feature selinux works if the required system packages are installed

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 29, 2021
@BillyONeal
Copy link
Member

BillyONeal commented Nov 29, 2021

RE: #21676 (comment)

These mean that the vcpkg binary returned a nonzero exit code for some reason:

    & "./vcpkg$executableExtension" ci $Triplet --x-xunit=$xmlFile --exclude=$skipList --failure-logs=$failureLogs @hostArgs @commonArgs @cachingArgs @parentHashes

    $failureLogsEmpty = (-Not (Test-Path $failureLogs) -Or ((Get-ChildItem $failureLogs).count -eq 0))
    Write-Host "##vso[task.setvariable variable=FAILURE_LOGS_EMPTY]$failureLogsEmpty"

    if ($LASTEXITCODE -ne 0)
    {
        throw "vcpkg ci failed"
    }

This osx error already appeared randomly in the last weeks.

Hmmm I have not seen yet. Is it always the same build node or something else?

@BillyONeal BillyONeal merged commit 60a8f79 into microsoft:master Nov 29, 2021
@BillyONeal
Copy link
Member

Thanks for the update!

@Neumann-A Neumann-A deleted the update_glib_2.70.1 branch November 29, 2021 20:33
@BillyONeal
Copy link
Member

@BillyONeal Where do I see the node?

If you click on 'x64-osx' on those links it shows the node in the output window:

image

Both those examples ran on vcpkg-eg-mac-06 which suggests that that one is unhealthy. I disabled it for now

@BillyONeal BillyONeal mentioned this pull request Nov 29, 2021
1 task
@BillyONeal
Copy link
Member

I vagrant destroy && vagrant up'd -06 so it should be back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[glib] update to 2.69.3
4 participants