Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libdc1394] Add new port #21808

Merged
merged 9 commits into from
Dec 7, 2021
Merged

Conversation

nzqpeace
Copy link
Contributor

@nzqpeace nzqpeace commented Dec 2, 2021

Describe the pull request
Port a new package, library dc1394

  • Which triplets are supported/not supported? Have you updated the [CI baseline]

linux, osx

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@ghost
Copy link

ghost commented Dec 2, 2021

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 self-assigned this Dec 2, 2021
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 2, 2021
ports/libdc1394/vcpkg.json Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libdc1394 but no changes to version or port version.
-- Version: 2.2.6
-- Old SHA: 057096e218b3f33feb531f32966d12aa26345021
-- New SHA: 16bd0e66515ac00a4f6bcfe618b4f9d28fd103c5
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

ports/libdc1394/vcpkg.json Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Dec 2, 2021
ports/libdc1394/portfile.cmake Outdated Show resolved Hide resolved
@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Dec 3, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Dec 6, 2021
@JonLiu1993 JonLiu1993 changed the title [libdc1394] port library dc1394 [libdc1394] Add new port Dec 6, 2021
@BillyONeal BillyONeal merged commit 4010c73 into microsoft:master Dec 7, 2021
@BillyONeal
Copy link
Member

Thanks for the new port and for the vcpkg_from_sourceforge edit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants